[cli] Print non-live spinner messages cleanly

When stdout is not live, keep callback-visible output while avoiding
spinner control-sequence clutter.

Make start(message) print only the message in non-live mode and return
early in stop() for non-live mode. Keep print() behavior unchanged so
log lines continue to be emitted by spinner callbacks.

Add unit tests covering non-live logging, reply, and iterative spinner
callbacks.

Author: riken127

src/client/cli/cmd/animated_spinner.cpp

@@ -43,14 +43,17 @@ mp::AnimatedSpinner::~AnimatedSpinner()
 void mp::AnimatedSpinner::start(const std::string& start_message)
 {
     if (!is_live)
+    {
+        current_message = start_message;
+        cout << start_message << std::flush;
         return;
+    }
 
     std::unique_lock<decltype(mutex)> lock{mutex};
     if (!running)
     {
         current_message = start_message;
         running = true;
-
         clear_line(cout);
         cout << start_message << "  " << std::flush;
         t = std::thread(&AnimatedSpinner::draw, this);
@@ -65,7 +68,7 @@ void mp::AnimatedSpinner::start()
 
 void mp::AnimatedSpinner::stop()
 {
-    if(!is_live)
+    if (!is_live)
         return;
 
     std::unique_lock<decltype(mutex)> lock{mutex};
@@ -77,16 +80,11 @@ void mp::AnimatedSpinner::stop()
         if (t.joinable())
             t.join();
     }
-
-    
     clear_line(cout);
 }
 
 void mp::AnimatedSpinner::print(std::ostream& stream, const std::string& message)
 {
-    if (!is_live)
-        return;
-    
     stop();
 
     stream << message;

tests/unit/test_common_callbacks.cpp

@@ -199,3 +199,55 @@ TEST_F(TestSpinnerCallbacks, confirmationCallbackAnswers)
     EXPECT_THAT(err.str(), IsEmpty());
     EXPECT_THAT(out.str(), clearStreamMatcher());
 }
+
+TEST_F(TestSpinnerCallbacks, nonLiveLoggingSpinnerCallbackLogsWithoutSpinnerArtifacts)
+{
+    constexpr auto log = "message in a bottle";
+    mp::AnimatedSpinner non_live_spinner{out, false};
+
+    mp::MountReply reply;
+    reply.set_log_line(log);
+
+    auto cb =
+        mp::make_logging_spinner_callback<mp::MountRequest, mp::MountReply>(non_live_spinner, err);
+    cb(reply, nullptr);
+
+    EXPECT_THAT(err.str(), StrEq(log));
+    EXPECT_THAT(out.str(), IsEmpty());
+}
+
+TEST_F(TestSpinnerCallbacks, nonLiveReplySpinnerCallbackPrintsAllMessagesWithoutSpinnerArtifacts)
+{
+    constexpr auto log = "message in a bottle";
+    constexpr auto msg = "answer";
+    mp::AnimatedSpinner non_live_spinner{out, false};
+
+    mp::MountReply reply;
+    reply.set_log_line(log);
+    reply.set_reply_message(msg);
+
+    auto cb =
+        mp::make_reply_spinner_callback<mp::MountRequest, mp::MountReply>(non_live_spinner, err);
+    cb(reply, nullptr);
+
+    EXPECT_THAT(err.str(), StrEq(log));
+    EXPECT_THAT(out.str(), StrEq(msg));
+}
+
+TEST_F(TestSpinnerCallbacks, nonLiveIterativeSpinnerCallbackPrintsAllMessagesWithoutSpinnerArtifacts)
+{
+    constexpr auto log = "message in a bottle";
+    constexpr auto msg = "answer";
+    mp::AnimatedSpinner non_live_spinner{out, false};
+
+    mp::MountReply reply;
+    reply.set_log_line(log);
+    reply.set_reply_message(msg);
+
+    auto cb = mp::make_iterative_spinner_callback<mp::MountRequest, mp::MountReply>(
+        non_live_spinner, term);
+    cb(reply, nullptr);
+
+    EXPECT_THAT(err.str(), StrEq(log));
+    EXPECT_THAT(out.str(), StrEq(msg));
+}