Skip to content

Commit 178f86b

Browse files
lengaujahn-junior
andauthored
fix(launchpad): don't bypass proxy environment variables (#5785)
Co-authored-by: JJ Coldiron <jj.coldiron@canonical.com>
1 parent 17ec09c commit 178f86b

File tree

3 files changed

+20
-0
lines changed

3 files changed

+20
-0
lines changed

docs/release-notes/snapcraft-8-12.rst

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -91,6 +91,11 @@ Snapcraft 8.12.0
9191

9292
- `#5696`_ YAML structure is not validated before preprocessing
9393

94+
Snapcraft 8.12.1
95+
~~~~~~~~~~~~~~~~
96+
97+
- Launchpad requests ignore ``HTTP_PROXY``
98+
9499
Contributors
95100
------------
96101

pyproject.toml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,10 @@ dependencies = [
88
"click>=8.2",
99
# Pinned due to https://github.com/canonical/craft-application/issues/891
1010
"craft-application[remote]>=5.7.0,<5.9.0",
11+
# So that launchpadlib can use proxies.
12+
# See: https://github.com/httplib2/httplib2/issues/251
13+
# This can be removed once we have craft-application >= 5.10.2
14+
"pysocks~=1.7",
1115
"craft-archives~=2.1",
1216
"craft-cli>=3.1.2,<4.0.0",
1317
"craft-grammar>=2.0.3,<3.0.0",

uv.lock

Lines changed: 11 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)