repo: set priority to critical for debs

Only show "Questions that you really, really need to see
(or else)."

LP: #1821313

Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>

Author: Sergio Schvezov

snapcraft/internal/repo/_deb.py

@@ -375,10 +375,20 @@ def _install_new_build_packages(cls, package_names: List[str]) -> None:
         logger.info("Installing build dependencies: %s", " ".join(package_names))
         env = os.environ.copy()
         env.update(
-            {"DEBIAN_FRONTEND": "noninteractive", "DEBCONF_NONINTERACTIVE_SEEN": "true"}
+            {
+                "DEBIAN_FRONTEND": "noninteractive",
+                "DEBCONF_NONINTERACTIVE_SEEN": "true",
+                "DEBIAN_PRIORITY": "critical",
+            }
         )
 
-        apt_command = ["sudo", "apt-get", "--no-install-recommends", "-y"]
+        apt_command = [
+            "sudo",
+            "--preserve-env",
+            "apt-get",
+            "--no-install-recommends",
+            "-y",
+        ]
         if not is_dumb_terminal():
             apt_command.extend(["-o", "Dpkg::Progress-Fancy=1"])
         apt_command.append("install")

spread.yaml

@@ -19,6 +19,10 @@ environment:
   # Disable all Sentry error reporting
   SNAPCRAFT_ENABLE_ERROR_REPORTING: "no"
 
+  # Ensure that we have the right debian configuration for legacy
+  DEBIAN_FRONTEND: noninteractive
+  DEBIAN_PRIORITY: critical
+
   TOOLS_DIR: /snapcraft/tests/spread/tools
 
 backends:

tests/unit/repo/test_deb.py

@@ -477,12 +477,13 @@ def test_install_build_package(self, mock_check_call, mock_is_dumb_terminal):
         mock_check_call.assert_has_calls(
             [
                 call(
-                    "sudo apt-get --no-install-recommends -y "
+                    "sudo --preserve-env apt-get --no-install-recommends -y "
                     "-o Dpkg::Progress-Fancy=1 install".split()
                     + sorted(set(installable)),
                     env={
                         "DEBIAN_FRONTEND": "noninteractive",
                         "DEBCONF_NONINTERACTIVE_SEEN": "true",
+                        "DEBIAN_PRIORITY": "critical",
                     },
                 )
             ]
@@ -500,11 +501,12 @@ def test_install_buid_package_in_dumb_terminal(
         mock_check_call.assert_has_calls(
             [
                 call(
-                    "sudo apt-get --no-install-recommends -y install".split()
+                    "sudo --preserve-env apt-get --no-install-recommends -y install".split()
                     + sorted(set(installable)),
                     env={
                         "DEBIAN_FRONTEND": "noninteractive",
                         "DEBCONF_NONINTERACTIVE_SEEN": "true",
+                        "DEBIAN_PRIORITY": "critical",
                     },
                 )
             ]
@@ -522,6 +524,7 @@ def test_install_buid_package_marks_auto_installed(self, mock_check_call):
                     env={
                         "DEBIAN_FRONTEND": "noninteractive",
                         "DEBCONF_NONINTERACTIVE_SEEN": "true",
+                        "DEBIAN_PRIORITY": "critical",
                     },
                 )
             ]