many: inline constant to fix govet err (#17021)

Signed-off-by: Miguel Pires <miguel.pires@canonical.com>

Author: miguelpires

metautil/type_conversions.go

@@ -97,7 +97,7 @@ func (e AttributeNotCompatibleError) Is(target error) bool {
 // the val parameter, which therefore must be a pointer.
 func SetValueFromAttribute(snapName string, ifaceName string, attrName string, attrVal any, val any) error {
 	rt := reflect.TypeOf(val)
-	if rt.Kind() != reflect.Ptr || val == nil {
+	if rt.Kind() != reflect.Pointer || val == nil {
 		return fmt.Errorf("internal error: cannot get %q attribute of interface %q with non-pointer value", attrName, ifaceName)
 	}
 

store/details_v2_test.go

@@ -490,9 +490,9 @@ func (s *detailsV2Suite) TestInfoFromStoreSnap(c *C) {
 
 // arg must be a pointer to a struct
 func fillStruct(a any, c *C) {
-	if t := reflect.TypeOf(a); t.Kind() != reflect.Ptr || t.Elem().Kind() != reflect.Struct {
+	if t := reflect.TypeOf(a); t.Kind() != reflect.Pointer || t.Elem().Kind() != reflect.Struct {
 		k := t.Kind()
-		if k == reflect.Ptr {
+		if k == reflect.Pointer {
 			k = t.Elem().Kind()
 		}
 		c.Fatalf("first argument must be expected a pointer to a struct, not %s", k)

testutil/base.go

@@ -91,7 +91,7 @@ func backupMockables(mockablesByPtr []any) (backup []*reflect.Value) {
 	for i, ptr := range mockablesByPtr {
 		mockedPtr := reflect.ValueOf(ptr)
 
-		if mockedPtr.Type().Kind() != reflect.Ptr {
+		if mockedPtr.Type().Kind() != reflect.Pointer {
 			panic("Backup: each mockable must be passed by pointer!")
 		}