o/ifacestate: properly handle undo scenarios where auto-connections are dropped

Author: andrewphelpsj

overlord/ifacestate/handlers.go

@@ -369,10 +369,13 @@ func (m *InterfaceManager) refreshAppSetConnections(task *state.Task, appSet *in
 		task.Logf("%s", snap.BadInterfacesSummary(snapInfo))
 	}
 
-	affectedConnections, err := m.reloadConnections(snapName)
+	affectedConnections, changedConns, err := m.reloadConnections(snapName)
 	if err != nil {
 		return nil, nil, err
 	}
+	if err := saveChangedConnectionsForSetupProfilesRestore(task, snapName, changedConns); err != nil {
+		return nil, nil, err
+	}
 	return disconnectedSnaps, affectedConnections, nil
 }
 
@@ -696,6 +699,9 @@ func (m *InterfaceManager) undoSetupProfiles(task *state.Task, tomb *tomb.Tomb)
 	if err := snapstateFinishRestart(task, snapsup, finishOpts); err != nil {
 		return err
 	}
+	if err := restoreConnectionsForSetupProfiles(task); err != nil {
+		return err
+	}
 
 	// Get the name from SnapSetup and use it to find the current SideInfo
 	// about the snap, if there is one.
@@ -2003,7 +2009,7 @@ func (m *InterfaceManager) transitionConnectionsCoreMigration(st *state.State, o
 	// on disk are rewritten. This is ok because core/ubuntu-core have
 	// exactly the same profiles and nothing in the generated policies
 	// has the core snap-name encoded.
-	if _, err := m.reloadConnections(newName); err != nil {
+	if _, _, err := m.reloadConnections(newName); err != nil {
 		return err
 	}
 

overlord/ifacestate/helpers.go

@@ -426,15 +426,93 @@ func isBroken(st *state.State, snapName string) (bool, error) {
 	return false, nil
 }
 
+func cloneConnAttrs(attrs map[string]any) map[string]any {
+	if attrs == nil {
+		return nil
+	}
+	return utils.CopyAttributes(attrs)
+}
+
+func cloneConnState(connState *schema.ConnState) *schema.ConnState {
+	clone := *connState
+	clone.StaticPlugAttrs = cloneConnAttrs(connState.StaticPlugAttrs)
+	clone.DynamicPlugAttrs = cloneConnAttrs(connState.DynamicPlugAttrs)
+	clone.StaticSlotAttrs = cloneConnAttrs(connState.StaticSlotAttrs)
+	clone.DynamicSlotAttrs = cloneConnAttrs(connState.DynamicSlotAttrs)
+	return &clone
+}
+
+// saveChangedConnectionsForSetupProfilesRestore records original connection
+// states for setup-profiles do tasks whose undo can restore them.
+func saveChangedConnectionsForSetupProfilesRestore(task *state.Task, instanceName string, changedConns map[string]*schema.ConnState) error {
+	if len(changedConns) == 0 {
+		return nil
+	}
+
+	// undo setup-profiles also calls this code while rebuilding old profiles,
+	// but restoration data should only come from the original do path
+	if task.Status() == state.UndoingStatus {
+		return nil
+	}
+
+	if !shouldUndoSetupProfiles(task, instanceName) {
+		return nil
+	}
+
+	var originalConns map[string]*schema.ConnState
+	err := task.Get("original-connection-states", &originalConns)
+	if err != nil && !errors.Is(err, state.ErrNoState) {
+		return err
+	}
+	if originalConns == nil {
+		originalConns = make(map[string]*schema.ConnState)
+	}
+	for connID, connState := range changedConns {
+		if originalConns[connID] != nil {
+			// a setup-profiles task can be retried after saving original states
+			// and unlocking for backend setup. keep the original snapshot.
+			continue
+		}
+		originalConns[connID] = connState
+	}
+
+	task.Set("original-connection-states", originalConns)
+	return nil
+}
+
+// restoreConnectionsForSetupProfiles restores connection states saved on a
+// setup-profiles task.
+func restoreConnectionsForSetupProfiles(task *state.Task) error {
+	var originalConns map[string]*schema.ConnState
+	err := task.Get("original-connection-states", &originalConns)
+	if errors.Is(err, state.ErrNoState) {
+		return nil
+	}
+	if err != nil {
+		return err
+	}
+
+	conns, err := getConns(task.State())
+	if err != nil {
+		return err
+	}
+	for connID, connState := range originalConns {
+		conns[connID] = cloneConnState(connState)
+	}
+	setConns(task.State(), conns)
+	return nil
+}
+
 // reloadConnections reloads connections stored in the state in the repository.
 // Using non-empty snapName the operation can be scoped to connections
 // affecting a given snap.
 //
-// The return value is the list of affected snap names and their connection IDs.
-func (m *InterfaceManager) reloadConnections(snapName string) (reloadedConnectionIDs []string, err error) {
+// The return value is the list of affected snap names and their connection IDs,
+// plus the original connection states that were changed.
+func (m *InterfaceManager) reloadConnections(snapName string) (reloadedConnectionIDs []string, changedConns map[string]*schema.ConnState, err error) {
 	conns, err := getConns(m.state)
 	if err != nil {
-		return nil, err
+		return nil, nil, err
 	}
 
 	var policyChecker interfaces.PolicyFunc
@@ -445,21 +523,22 @@ func (m *InterfaceManager) reloadConnections(snapName string) (reloadedConnectio
 	if errors.Is(err, state.ErrNoState) {
 		// everything else is a noop, as no model means no connections
 		// to reload
-		return nil, nil
+		return nil, nil, nil
 	} else if err != nil {
-		return nil, err
+		return nil, nil, err
 	}
 	autoChecker, err = newAutoConnectChecker(m.state, m.repo, deviceCtx)
 	if err != nil {
-		return nil, err
+		return nil, nil, err
 	}
 
 	connChecker, err = newConnectChecker(m.state, deviceCtx)
 	if err != nil {
-		return nil, err
+		return nil, nil, err
 	}
 
 	connStateChanged := false
+	changedConns = make(map[string]*schema.ConnState)
 
 	var reloadedConnections []string
 ConnsLoop:
@@ -473,7 +552,7 @@ ConnsLoop:
 		}
 		connRef, err := interfaces.ParseConnRef(connId)
 		if err != nil {
-			return nil, err
+			return nil, nil, err
 		}
 		// Apply filtering, this allows us to reload only a subset of
 		// connections (and similarly, refresh the static attributes of only a
@@ -497,13 +576,14 @@ ConnsLoop:
 				for _, snapName := range []string{connRef.PlugRef.Snap, connRef.SlotRef.Snap} {
 					broken, err := isBroken(m.state, snapName)
 					if err != nil {
-						return nil, err
+						return nil, nil, err
 					}
 					if broken {
 						logger.Noticef("Snap %q is broken, ignored by reloadConnections", snapName)
 						continue ConnsLoop
 					}
 				}
+				changedConns[connId] = cloneConnState(connState)
 				delete(conns, connId)
 				connStateChanged = true
 			}
@@ -540,11 +620,11 @@ ConnsLoop:
 
 		plugAppSet, err := interfaces.NewSnapAppSet(plugInfo.Snap, nil)
 		if err != nil {
-			return nil, err
+			return nil, nil, err
 		}
 		slotAppSet, err := interfaces.NewSnapAppSet(slotInfo.Snap, nil)
 		if err != nil {
-			return nil, err
+			return nil, nil, err
 		}
 
 		cplug := interfaces.NewConnectedPlug(plugInfo, plugAppSet, newStaticPlugAttrs, connState.DynamicPlugAttrs)
@@ -568,6 +648,7 @@ ConnsLoop:
 			reloadedConnections = append(reloadedConnections, connId)
 
 			if updateStaticAttrs {
+				changedConns[connId] = cloneConnState(connState)
 				connState.StaticPlugAttrs = staticPlugAttrs
 				connState.StaticSlotAttrs = staticSlotAttrs
 				connStateChanged = true
@@ -578,7 +659,7 @@ ConnsLoop:
 		setConns(m.state, conns)
 	}
 
-	return reloadedConnections, nil
+	return reloadedConnections, changedConns, nil
 }
 
 // removeConnections disconnects all connections of the snap in the repo. It should only be used if the snap

overlord/ifacestate/ifacemgr.go

@@ -206,7 +206,7 @@ func (m *InterfaceManager) StartUp() error {
 	if err := removeStaleConnections(m.state); err != nil {
 		return err
 	}
-	if _, err := m.reloadConnections(""); err != nil {
+	if _, _, err := m.reloadConnections(""); err != nil {
 		return err
 	}