ci: Ensure all apt install have -y - #16655
Merged
olivercalder merged 1 commit intoMay 7, 2026
Merged
Conversation
sergio-costas
force-pushed
the
ensure-all-apt-install-have-yes-option
branch
from
February 24, 2026 11:51
959fcb0 to
6ddc1a1
Compare
|
Wed Apr 29 21:09:36 UTC 2026 Failures:Executing:
Restoring:
Skipped tests from snapd-testing-skipIf you wish to have any of the below tests run in your PR, in your PR description, add 'unskip:' followed by a copy-and-pasted list (without variants) of the below tests you wish to run (unskip plus test list must be valid yaml)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #16655 +/- ##
==========================================
- Coverage 79.06% 79.04% -0.02%
==========================================
Files 1368 1376 +8
Lines 190680 190800 +120
Branches 2465 2465
==========================================
+ Hits 150758 150823 +65
- Misses 30835 30891 +56
+ Partials 9087 9086 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sergio-costas
force-pushed
the
ensure-all-apt-install-have-yes-option
branch
3 times, most recently
from
March 10, 2026 11:14
b6474a2 to
57dc0cf
Compare
sergio-costas
force-pushed
the
ensure-all-apt-install-have-yes-option
branch
from
April 15, 2026 07:34
57dc0cf to
fb6ead1
Compare
Contributor
Author
|
@olivercalder Also this one, please. It's a very simple one. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates CI/test scripts to make apt install non-interactive by consistently passing -y, reducing the chance of future failures due to prompts when dependencies change.
Changes:
- Normalize
apt installcalls to include-yin a nested manual test task. - Add
-ytoapt installsteps in GitHub Actions workflows (main repo and snapd-testing-tools).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/nested/manual/hybrid-fde-all-key-databases/task.yaml | Makes remote apt install non-interactive for efitools during test preparation. |
| tests/lib/external/snapd-testing-tools/.github/workflows/tests.yaml | Adds -y to apt install for python3-pip in the codespell job step. |
| .github/workflows/nightly-firefox-performance.yaml | Adds -y to apt install for xvfb in both Firefox performance jobs. |
| .github/workflows/ci-test.yaml | Adds -y to apt install for texinfo/autopoint in cached build-deps job. |
| .github/workflows/ci-master-push.yaml | Adds -y to apt install for texinfo/autopoint in cached build-deps job. |
Contributor
|
@sergio-costas can you rebase on latest master? |
sergio-costas
force-pushed
the
ensure-all-apt-install-have-yes-option
branch
from
April 29, 2026 08:37
fb6ead1 to
51d31cc
Compare
Contributor
Author
|
Rebased. |
bboozzoo
added
the
Auto rerun spread
During tests, a lot of .deb packages are installed. In some cases, the -y parameter is missing, which may cause problems in the future if the package to install have new dependencies. This patch ensures that all apt install calls do have the -y parameter.
sergio-costas
force-pushed
the
ensure-all-apt-install-have-yes-option
branch
from
April 29, 2026 17:22
51d31cc to
4cf65c8
Compare
Contributor
Author
|
And re-rebased. Let's see if now it passes everything... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During tests, a lot of .deb packages are installed. In some cases, the -y parameter is missing, which may cause problems in the future if the package to install have new dependencies.
This patch ensures that all apt install calls do have the -y parameter.
Thanks for helping us make a better snapd!
Have you signed the license agreement and read the contribution guide?