Requests by reviewer: bugfixes

Author: H-Grobben

canopen/sdo/exceptions.py

@@ -52,7 +52,7 @@ def __init__(self, code: Union[int, str]):
             except ValueError as e:
                 raise ValueError(f"Unknown SDO abort description: {code}") from e
         else:
-        self.code = code
+            self.code = code
 
     def __str__(self):
         text = f"Code 0x{self.code:08X}"

test/test_local.py

@@ -37,13 +37,14 @@ def test_expedited_upload(self):
         vendor_id = self.remote_node.sdo[0x1400][1].raw
         self.assertEqual(vendor_id, 0x99)
 
-    def test_block_upload_switch_to_expedite_upload(self):
-        with self.assertRaises(canopen.SdoCommunicationError) as context:
-            with self.remote_node.sdo[0x1008].open('r', block_transfer=True) as fp:
-                pass
-        # We get this since the sdo client don't support the switch
-        # from block upload to expedite upload
-        self.assertEqual("Unexpected response 0x41", str(context.exception))
+    # Remove this test, as Block upload is now supported:
+    # def test_block_upload_switch_to_expedite_upload(self):
+    #     with self.assertRaises(canopen.SdoCommunicationError) as context:
+    #         with self.remote_node.sdo[0x1008].open('r', block_transfer=True) as fp:
+    #             pass
+    #     # We get this since the sdo client don't support the switch
+    #     # from block upload to expedite upload
+    #     self.assertEqual("Unexpected response 0x41", str(context.exception))
 
     def test_block_download_not_supported(self):
         data = b"TEST DEVICE"

test/test_sdo.py

@@ -4,7 +4,7 @@
 import canopen.objectdictionary.datatypes as dt
 from canopen.objectdictionary import ODVariable
 
-from util import DATATYPES_EDS, SAMPLE_EDS
+from .util import DATATYPES_EDS, SAMPLE_EDS
 
 
 TX = 1