Skip to content

Commit e15bec4

Browse files
committed
Merge branch 'master' into mypy
2 parents 315cab0 + 28ee18c commit e15bec4

File tree

2 files changed

+9
-7
lines changed

2 files changed

+9
-7
lines changed

canopen/network.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -372,9 +372,6 @@ class NodeScanner:
372372
The network to use when doing active searching.
373373
"""
374374

375-
#: Activate or deactivate scanning
376-
active = True
377-
378375
SERVICES = (0x700, 0x580, 0x180, 0x280, 0x380, 0x480, 0x80)
379376

380377
def __init__(self, network: Optional[Network] = None):

test/test_network.py

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -321,23 +321,28 @@ def test_scanner_search_no_network(self):
321321
self.scanner.search()
322322

323323
def test_scanner_search(self):
324-
bus = can.Bus(interface="virtual", receive_own_messages=True)
325-
net = canopen.Network(bus)
324+
rxbus = can.Bus(interface="virtual")
325+
self.addCleanup(rxbus.shutdown)
326+
327+
txbus = can.Bus(interface="virtual")
328+
self.addCleanup(txbus.shutdown)
329+
330+
net = canopen.Network(txbus)
326331
net.connect()
327332
self.addCleanup(net.disconnect)
328333

329334
self.scanner.network = net
330335
self.scanner.search()
331336

332337
payload = bytes([64, 0, 16, 0, 0, 0, 0, 0])
333-
acc = [bus.recv(self.TIMEOUT) for _ in range(127)]
338+
acc = [rxbus.recv(self.TIMEOUT) for _ in range(127)]
334339
for node_id, msg in enumerate(acc, start=1):
335340
with self.subTest(node_id=node_id):
336341
self.assertIsNotNone(msg)
337342
self.assertEqual(msg.arbitration_id, 0x600 + node_id)
338343
self.assertEqual(msg.data, payload)
339344
# Check that no spurious packets were sent.
340-
self.assertIsNone(bus.recv(self.TIMEOUT))
345+
self.assertIsNone(rxbus.recv(self.TIMEOUT))
341346

342347
def test_scanner_search_limit(self):
343348
bus = can.Bus(interface="virtual", receive_own_messages=True)

0 commit comments

Comments
 (0)