Skip to content

Commit b8de173

Browse files
committed
Revert "feat: update diff editor"
This reverts commit d11c5fa.
1 parent d11c5fa commit b8de173

File tree

10 files changed

+36
-219
lines changed

10 files changed

+36
-219
lines changed

packages/canyon-backend/src/app.module.ts

-2
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import { TypeOrmModule } from "@nestjs/typeorm";
1818
import { CollectModule } from "./apps/collect/collect.module";
1919
import { CoveragediskEntity } from "./apps/collect/entity/coveragedisk.entity";
2020
import { ApolloServerPluginLandingPageLocalDefault } from '@apollo/server/plugin/landingPage/default';
21-
import {CodeModule} from "./code/code.module";
2221

2322

2423
@Module({
@@ -38,7 +37,6 @@ import {CodeModule} from "./code/code.module";
3837
CoverageModule,
3938
CodechangeModule,
4039
SourcecodeModule,
41-
CodeModule,
4240
ServeStaticModule.forRoot({
4341
rootPath: join(__dirname, "../../canyon-platform", "dist"),
4442
exclude: ["/graphql"], // 这样就不会触发 path-to-regexp 解析错误

packages/canyon-backend/src/code/code.controller.ts

-44
This file was deleted.

packages/canyon-backend/src/code/code.module.ts

-11
This file was deleted.

packages/canyon-backend/src/code/code.service.ts

-25
This file was deleted.

packages/canyon-backend/src/code/codechange2.service.ts

-46
This file was deleted.

packages/canyon-platform/src/pages/index/projects/[id]/commits/[sha]/[...filepath].tsx

-1
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ const Sha = () => {
9191
fileContent: res.fileContent,
9292
fileCoverage: res.fileCoverage,
9393
fileCodeChange: res.fileCodeChange,
94-
fileCodeChangeContent: res.fileCodeChangeContent,
9594
};
9695
});
9796
}}

packages/canyon-platform/src/pages/index/projects/[id]/commits/helper/index.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ export function handleSelectFile({
1515
reportID,
1616
}: HandleSelectFile) {
1717
const fileContentRequest = axios
18-
.get(`/api/code`, {
18+
.get(`/api/sourcecode`, {
1919
params: {
2020
projectID: projectID,
2121
sha: sha,
@@ -52,7 +52,6 @@ export function handleSelectFile({
5252
fileContent: getDecode(fileContent.content),
5353
fileCoverage: fileCoverage,
5454
fileCodeChange: fileCodeChange.additions || [],
55-
fileCodeChangeContent: getDecode(fileContent.oldContent),
5655
};
5756
});
5857
}

packages/canyon-report/src/components/report.tsx

-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ const onSelectDefault = () => {
1515
fileContent: "",
1616
fileCoverage: emptyFileCoverageData,
1717
fileCodeChange: [],
18-
fileCodeChangeContent: "",
1918
});
2019
};
2120

@@ -39,7 +38,6 @@ const Report: FC<ReportProps> = ({
3938
b: {},
4039
});
4140
const [fileContent, setFileContent] = useState<string>("");
42-
const [fileCodeChangeContent, setFileCodeChangeContent] = useState<string>("");
4341
const [fileCodeChange, setFileCodeChange] = useState<number[]>([]);
4442
const [onlyChange, setOnlyChange] = useState(Boolean(defaultOnlyShowChanged));
4543

@@ -48,7 +46,6 @@ const Report: FC<ReportProps> = ({
4846
setFileContent(res.fileContent);
4947
setFileCoverage(res.fileCoverage);
5048
setFileCodeChange(res.fileCodeChange);
51-
setFileCodeChangeContent(res.fileCodeChangeContent);
5249
return res;
5350
}
5451

@@ -146,7 +143,6 @@ const Report: FC<ReportProps> = ({
146143
Object.keys(fileCoverage).length > 0 &&
147144
Object.keys(fileContent).length > 0 && (
148145
<FileCoverageDetail
149-
fileCodeChangeContent={fileCodeChangeContent}
150146
fileContent={fileContent}
151147
fileCodeChange={fileCodeChange}
152148
fileCoverage={fileCoverage}

packages/canyon-report/src/components/types.ts

-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ export interface ReportProps {
88
fileCoverage: FileCoverageData;
99
fileContent: string;
1010
fileCodeChange: number[];
11-
fileCodeChangeContent: string;
1211
}>;
1312
defaultOnlyShowChanged: boolean;
1413
}

packages/canyon-report/src/components/widgets/FileCoverageDetail.tsx

+35-83
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { FC, useEffect, useMemo, useRef, useState } from "react";
2-
import { DiffEditor, Editor } from "@monaco-editor/react";
2+
import { Editor } from "@monaco-editor/react";
33

44
// import * as monaco from "monaco-editor";
55
import {
@@ -14,21 +14,20 @@ const { useToken } = theme;
1414
const FileCoverageDetail: FC<{
1515
fileContent: string;
1616
fileCodeChange: number[];
17-
fileCodeChangeContent: string;
1817
fileCoverage: any;
19-
}> = ({ fileContent, fileCoverage, fileCodeChange, fileCodeChangeContent }) => {
18+
}> = ({ fileContent, fileCoverage, fileCodeChange }) => {
2019
const { token } = useToken();
2120
const { lines } = coreFn(fileCoverage, fileContent);
2221

2322
const linesState = useMemo(() => {
2423
return lines.map((line, index) => {
2524
return {
2625
lineNumber: index + 1,
27-
change: false,
26+
change: fileCodeChange.includes(index + 1),
2827
hit: line.executionNumber,
2928
};
3029
});
31-
}, [lines]);
30+
}, [lines, fileCodeChange]);
3231

3332
const lineNumbersMinChars = useMemo(() => {
3433
const maxHit = Math.max(...linesState.map((line) => line.hit));
@@ -63,20 +62,7 @@ const FileCoverageDetail: FC<{
6362
}
6463
useEffect(() => {
6564
if (editor) {
66-
let needDeltaDecorationsEditor = null;
67-
68-
if (fileCodeChangeContent) {
69-
const originalEditor = editor.getOriginalEditor();
70-
originalEditor.updateOptions({
71-
lineNumbers: false,
72-
});
73-
const modifiedEditor = editor.getModifiedEditor();
74-
needDeltaDecorationsEditor = modifiedEditor;
75-
} else {
76-
needDeltaDecorationsEditor = editor;
77-
}
78-
79-
needDeltaDecorationsEditor?.deltaDecorations?.(
65+
editor?.deltaDecorations?.(
8066
[], // oldDecorations 每次清空上次标记的
8167
decorations.map(
8268
({ inlineClassName, startLine, startCol, endLine, endCol }) => ({
@@ -105,70 +91,36 @@ const FileCoverageDetail: FC<{
10591
// border: "1px solid " + token.colorBorder,
10692
}}
10793
>
108-
{fileCodeChangeContent ? (
109-
<DiffEditor
110-
original={fileCodeChangeContent}
111-
modified={fileContent}
112-
// theme={"vs-dark"}
113-
height={"calc(100vh - 200px)"}
114-
// height={`${18 * (lineCount + 1)}px`}
115-
language={"javascript"}
116-
onMount={handleEditorDidMount}
117-
options={{
118-
lineHeight: 18,
119-
lineNumbers: (lineNumber) => {
120-
return lineNumbers(
121-
lineNumber,
122-
linesState,
123-
token.colorBgBase === "#000",
124-
);
125-
},
126-
lineNumbersMinChars: lineNumbersMinChars,
127-
readOnly: true,
128-
folding: false,
129-
minimap: { enabled: false },
130-
scrollBeyondLastLine: false,
131-
showUnused: false,
132-
fontSize: 12,
133-
fontFamily: "IBMPlexMono",
134-
scrollbar: {
135-
// handleMouseWheel: false,
136-
},
137-
contextmenu: false,
138-
}}
139-
/>
140-
) : (
141-
<Editor
142-
value={fileContent}
143-
theme={token.colorBgBase === "#000" ? "nightOwl" : "vs"}
144-
height={"calc(100vh - 200px)"}
145-
// height={`${18 * (lineCount + 1)}px`}
146-
language={"javascript"}
147-
onMount={handleEditorDidMount}
148-
options={{
149-
lineHeight: 18,
150-
lineNumbers: (lineNumber) => {
151-
return lineNumbers(
152-
lineNumber,
153-
linesState,
154-
token.colorBgBase === "#000",
155-
);
156-
},
157-
lineNumbersMinChars: lineNumbersMinChars,
158-
readOnly: true,
159-
folding: false,
160-
minimap: { enabled: false },
161-
scrollBeyondLastLine: false,
162-
showUnused: false,
163-
fontSize: 12,
164-
fontFamily: "IBMPlexMono",
165-
scrollbar: {
166-
// handleMouseWheel: false,
167-
},
168-
contextmenu: false,
169-
}}
170-
/>
171-
)}
94+
<Editor
95+
value={fileContent}
96+
theme={token.colorBgBase === "#000" ? "nightOwl" : "vs"}
97+
height={"calc(100vh - 200px)"}
98+
// height={`${18 * (lineCount + 1)}px`}
99+
language={"javascript"}
100+
onMount={handleEditorDidMount}
101+
options={{
102+
lineHeight: 18,
103+
lineNumbers: (lineNumber) => {
104+
return lineNumbers(
105+
lineNumber,
106+
linesState,
107+
token.colorBgBase === "#000",
108+
);
109+
},
110+
lineNumbersMinChars: lineNumbersMinChars,
111+
readOnly: true,
112+
folding: false,
113+
minimap: { enabled: false },
114+
scrollBeyondLastLine: false,
115+
showUnused: false,
116+
fontSize: 12,
117+
fontFamily: "IBMPlexMono",
118+
scrollbar: {
119+
// handleMouseWheel: false,
120+
},
121+
contextmenu: false,
122+
}}
123+
/>
172124
</div>
173125
);
174126
};

0 commit comments

Comments
 (0)