[ADVAPP-1728]: Bug Fix: Attempts to Send Alert to a Deleted User (#1742)

* [ADVAPP-1728]: Bug Fix: Deleted User Subscription

* [ADVAPP-1728]: Bug Fix: Deleted User Subscription

* [ADVAPP-1728]: Create a test for the issue.

* [ADVAPP-1728]: Fix the issue.

* [ADVAPP-1728]: Add a Todo

---------

Co-authored-by: Karl Murray <karl.murray@canyongbs.com>

Author: krlmrr

app-modules/alert/tests/Tenant/AlertCreateTest.php

@@ -79,3 +79,26 @@
     Notification::assertSentTo($users, AlertCreatedNotification::class);
     Notification::assertSentTimes(AlertCreatedNotification::class, $student->subscriptions()->count());
 });
+
+it('only notifies active users of alerts', function () {
+    // @Todo: This tests works but we should change it to use the Listener instead of the Notification
+    Notification::fake();
+
+    $deletedUser = User::factory()->licensed(LicenseType::cases())->create();
+
+    /** @var Student $student */
+    $student = Student::factory()->create();
+
+    $student->subscriptions()->create([
+        'user_id' => $deletedUser->id,
+    ]);
+
+    $deletedUser->delete();
+
+    Alert::factory()->create([
+        'concern_id' => $student->sisid,
+        'concern_type' => Student::class,
+    ]);
+
+    Notification::assertNotSentTo($deletedUser, AlertCreatedNotification::class);
+});

app-modules/notification/src/Models/Concerns/HasSubscriptions.php

@@ -46,6 +46,6 @@ trait HasSubscriptions
      */
     public function subscriptions(): MorphMany
     {
-        return $this->morphMany(Subscription::class, 'subscribable');
+        return $this->morphMany(Subscription::class, 'subscribable')->whereHas('user');
     }
 }