[ADVAPP-2561]: Some users have reported issues with modals being layered correctly (#2457)

amit-canyon · web-flow · commit 9888d5af3bca · 2026-04-15T15:11:47.000Z
Some users have reported issues with modals being layered correctly
diff --git a/app-modules/ai/src/Filament/Resources/LegacyAiMessageLogs/LegacyAiMessageLogResource.php b/app-modules/ai/src/Filament/Resources/LegacyAiMessageLogs/LegacyAiMessageLogResource.php
@@ -110,7 +110,7 @@ public static function table(Table $table): Table
                     ->searchable(),
             ])
             ->recordActions([
-                ViewAction::make(),
+                ViewAction::make()->slideOver(),
                 DeleteAction::make(),
             ])
             ->toolbarActions([
diff --git a/app-modules/basic-needs/src/Filament/Actions/SendEmailAction.php b/app-modules/basic-needs/src/Filament/Actions/SendEmailAction.php
@@ -74,6 +74,7 @@ public static function make(string $view): Action
         return Action::make('send_email')
             ->label('Send Email')
             ->icon('heroicon-m-chat-bubble-bottom-center-text')
+            ->slideOver()
             ->modalHeading('Send Message')
             ->model(Engagement::class)
             ->authorize(fn () => Auth::user()->can('create', Engagement::class))
diff --git a/app-modules/campaign/src/Filament/Resources/Campaigns/RelationManagers/CampaignActionsRelationManager.php b/app-modules/campaign/src/Filament/Resources/Campaigns/RelationManagers/CampaignActionsRelationManager.php
@@ -98,6 +98,7 @@ public function table(Table $table): Table
             ])
             ->headerActions([
                 Action::make('create')
+                    ->slideOver()
                     ->label('New')
                     ->modalHeading('Create Journey Steps')
                     ->schema([
@@ -151,6 +152,7 @@ public function table(Table $table): Table
                     })
                     ->databaseTransaction(),
                 EditAction::make()
+                    ->slideOver()
                     ->modalHeading(fn (CampaignAction $action) => 'Edit ' . $action->type->getLabel())
                     ->hidden(fn (CampaignAction $record) => $campaign->hasBeenExecuted() === true || $record->cancelled_at !== null)
                     ->mutateRecordDataUsing(function (array $data): array {
diff --git a/app-modules/care-team/src/Filament/Actions/AddCareTeamMemberToEducatableAttachAction.php b/app-modules/care-team/src/Filament/Actions/AddCareTeamMemberToEducatableAttachAction.php
@@ -64,6 +64,7 @@ protected function setUp(): void
         parent::setUp();
 
         $this->label('New')
+            ->slideOver()
             ->modalHeading(fn () => "Add Users to {$this->getLivewire()->getOwnerRecord()->display_name}'s Care Team")
             ->modalSubmitActionLabel('Add')
             ->modalWidth(Width::FourExtraLarge)
diff --git a/app-modules/engagement/src/Filament/Actions/BulkEmailAction.php b/app-modules/engagement/src/Filament/Actions/BulkEmailAction.php
@@ -70,6 +70,7 @@ public static function make(string $context): BulkAction
         return BulkAction::make('send_email')
             ->label('Send Email')
             ->icon('heroicon-o-envelope')
+            ->slideOver()
             ->modalHeading('Send Bulk Email')
             ->modalDescription(fn (Collection $records) => "You have selected {$records->count()} {$context} to send email.")
             ->model(EngagementBatch::class)
diff --git a/app-modules/engagement/src/Filament/Actions/RelationManagerSendEngagementAction.php b/app-modules/engagement/src/Filament/Actions/RelationManagerSendEngagementAction.php
@@ -79,6 +79,7 @@ protected function setUp(): void
 
         $this->icon('heroicon-m-chat-bubble-bottom-center-text')
             ->label('New')
+            ->slideOver()
             ->modalHeading('Send Message')
             ->modalDescription(function (RelationManager $livewire): string {
                 $educatable = $livewire->getOwnerRecord();
diff --git a/app-modules/engagement/src/Filament/Actions/SendEngagementAction.php b/app-modules/engagement/src/Filament/Actions/SendEngagementAction.php
@@ -81,6 +81,7 @@ protected function setUp(): void
         parent::setUp();
 
         $this->icon('heroicon-m-chat-bubble-bottom-center-text')
+            ->slideOver()
             ->modalHeading('Send Message')
             ->modalDescription(function (): ?string {
                 $educatable = $this->getEducatable();
diff --git a/app-modules/interaction/src/Filament/Concerns/HasManyMorphedInteractionsTrait.php b/app-modules/interaction/src/Filament/Concerns/HasManyMorphedInteractionsTrait.php
@@ -188,6 +188,7 @@ public function table(Table $table): Table
             ])
             ->headerActions([
                 CreateAction::make()
+                    ->slideOver()
                     ->steps(function () use ($ownerRecord) {
                         return InteractionForm::getSteps($ownerRecord);
                     })
@@ -197,13 +198,15 @@ public function table(Table $table): Table
             ])
             ->recordActions([
                 ViewAction::make()
+                    ->slideOver()
                     ->modalHeading('Interaction Details')
                     ->extraModalFooterActions([
                         DeleteAction::make()
                             ->modalHeading('Are you sure you wish to delete this interaction?')
                             ->cancelParentActions(),
                     ]),
                 EditAction::make()
+                    ->slideOver()
                     ->steps(function () use ($ownerRecord) {
                         return InteractionForm::getSteps($ownerRecord);
                     })
diff --git a/app-modules/project/src/Filament/Resources/Projects/Pages/ManageTasks.php b/app-modules/project/src/Filament/Resources/Projects/Pages/ManageTasks.php
@@ -92,6 +92,7 @@ public function table(Table $table): Table
             ])
             ->headerActions([
                 CreateAction::make()
+                    ->slideOver()
                     ->authorize(fn () => auth()->user()->can('create', [Task::class, null]))
                     ->schema([
                         Fieldset::make('Confidentiality')
@@ -146,6 +147,7 @@ public function table(Table $table): Table
             ])
             ->recordActions([
                 ViewAction::make()
+                    ->slideOver()
                     ->authorize('view', Task::class)
                     ->extraModalFooterActions([
                         Action::make('mark_as_in_progress')
@@ -226,6 +228,7 @@ public function table(Table $table): Table
                         ])->from('md'),
                     ]),
                 EditAction::make()
+                    ->slideOver()
                     ->schema([
                         Fieldset::make('Confidentiality')
                             ->schema([
diff --git a/app-modules/resource-hub/src/Filament/Resources/ResourceHubArticles/Pages/ListResourceHubArticles.php b/app-modules/resource-hub/src/Filament/Resources/ResourceHubArticles/Pages/ListResourceHubArticles.php
@@ -233,6 +233,7 @@ protected function getHeaderActions(): array
     {
         return [
             CreateAction::make()
+                ->slideOver()
                 ->disabled(fn (): bool => ! auth()->user()->can('resource_hub_article.create'))
                 ->createAnother(false)
                 ->successRedirectUrl(fn (Model $record): string => ResourceHubArticleResource::getUrl('edit', ['record' => $record])),
diff --git a/app-modules/student-data-model/src/Filament/Actions/ImportStudentDataAction.php b/app-modules/student-data-model/src/Filament/Actions/ImportStudentDataAction.php
@@ -222,6 +222,7 @@ public static function make(): ImportAction
 
         return $action
             ->label('Sync Records')
+            ->slideOver()
             ->importer(StudentImporter::class)
             ->authorize('import', Student::class)
             ->modalHeading('Synchronize Students, Programs, and Enrollments')
diff --git a/app-modules/student-data-model/src/Filament/Resources/Students/RelationManagers/EnrollmentsRelationManager.php b/app-modules/student-data-model/src/Filament/Resources/Students/RelationManagers/EnrollmentsRelationManager.php
@@ -183,8 +183,10 @@ public function table(Table $table): Table
                     ->searchable(),
             ])
             ->recordActions([
-                ViewAction::make(),
-                EditAction::make(),
+                ViewAction::make()
+                    ->slideOver(),
+                EditAction::make()
+                    ->slideOver(),
                 DeleteAction::make()
                     ->modalDescription('Are you sure you wish to delete the selected record(s)? This action cannot be reversed'),
             ])
@@ -239,7 +241,8 @@ public function table(Table $table): Table
                 ]),
             ])
             ->headerActions([
-                CreateAction::make(),
+                CreateAction::make()
+                    ->slideOver(),
                 ImportAction::make()
                     ->importer(EnrollmentImporter::class)
                     ->authorize('import', Enrollment::class)
diff --git a/app-modules/student-data-model/src/Filament/Resources/Students/RelationManagers/FormSubmissionsRelationManager.php b/app-modules/student-data-model/src/Filament/Resources/Students/RelationManagers/FormSubmissionsRelationManager.php
@@ -89,7 +89,8 @@ public function table(Table $table): Table
                 FormSubmissionStatusFilter::make(),
             ])
             ->headerActions([
-                RequestFormSubmission::make(),
+                RequestFormSubmission::make()
+                    ->slideOver(),
             ])
             ->recordActions([
                 ViewAction::make()
diff --git a/app-modules/student-data-model/src/Filament/Resources/Students/RelationManagers/ProgramsRelationManager.php b/app-modules/student-data-model/src/Filament/Resources/Students/RelationManagers/ProgramsRelationManager.php
@@ -155,8 +155,10 @@ public function table(Table $table): Table
             ])
             ->recordActions([
                 ViewAction::make()
+                    ->slideOver()
                     ->modalHeading('Program Information'),
                 EditAction::make()
+                    ->slideOver()
                     ->mutateRecordDataUsing(function (array $data): array {
                         $acadPlan = $data['acad_plan'] ?? [];
 
@@ -234,6 +236,7 @@ public function table(Table $table): Table
             ])
             ->headerActions([
                 CreateAction::make()
+                    ->slideOver()
                     ->using(function (array $data, RelationManager $livewire): Model {
                         $data['acad_plan'] = [
                             'major' => filled($data['acad_plan_major'] ?? null)
diff --git a/resources/css/filament/admin/theme.css b/resources/css/filament/admin/theme.css
@@ -409,11 +409,6 @@
     }
 }
 
-/* Modal Height */
-.fi-modal:not(.fi-modal-slide-over):not(.fi-width-screen) > .fi-modal-window-ctn > .fi-modal-window {
-    @apply max-h-[90dvh] overflow-y-auto;
-}
-
 .def-fo-searchable-input-dropdown-list-item {
     @apply dark:hover:bg-white/10 dark:active:bg-white/20;
 }
diff --git a/resources/views/vendor/filament-forms/components/builder/block-picker.blade.php b/resources/views/vendor/filament-forms/components/builder/block-picker.blade.php

Original file line number	Diff line number	Diff line change
`@@ -233,6 +233,7 @@ protected function getHeaderActions(): array`
`233`	`233`	`{`
`234`	`234`	`return [`
`235`	`235`	`CreateAction::make()`
	`236`	`+ ->slideOver()`
`236`	`237`	`->disabled(fn (): bool => ! auth()->user()->can('resource_hub_article.create'))`
`237`	`238`	`->createAnother(false)`
`238`	`239`	`->successRedirectUrl(fn (Model $record): string => ResourceHubArticleResource::getUrl('edit', ['record' => $record])),`