Skip to content

Commit b466380

Browse files
optimize query
1 parent 71ce242 commit b466380

2 files changed

Lines changed: 11 additions & 11 deletions

File tree

app-modules/alert/src/Presets/Handlers/NewInboundMessagePresetHandler.php

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -68,14 +68,14 @@ public function getConfigurationModel(): ?string
6868
public function getStudentAlertQuery(?AlertPresetConfiguration $configuration): Builder
6969
{
7070
return DB::table('students')
71-
->select('students.sisid')
72-
->join('engagement_responses', function (JoinClause $join) {
73-
$join->on('students.sisid', '=', 'engagement_responses.sender_id')
74-
->where('engagement_responses.sender_type', '=', 'student');
75-
})
76-
->where('engagement_responses.status', EngagementResponseStatus::New->value)
77-
->whereNull('students.deleted_at')
78-
->whereNull('engagement_responses.deleted_at')
79-
->distinct();
71+
->select('students.sisid')
72+
->join('engagement_responses', function (JoinClause $join) {
73+
$join->on('students.sisid', '=', 'engagement_responses.sender_id')
74+
->where('engagement_responses.sender_type', '=', 'student')
75+
->where('engagement_responses.status', EngagementResponseStatus::New->value)
76+
->whereNull('engagement_responses.deleted_at');
77+
})
78+
->whereNull('students.deleted_at')
79+
->distinct();
8080
}
8181
}

app-modules/engagement/database/migrations/2026_01_21_102338_add_index_in_engagement_responses_table.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,14 +42,14 @@
4242
public function up(): void
4343
{
4444
Schema::table('engagement_responses', function (Blueprint $table) {
45-
$table->index(['sender_type', 'sender_id', 'status']);
45+
$table->index(['sender_id', 'sender_type','status']);
4646
});
4747
}
4848

4949
public function down(): void
5050
{
5151
Schema::table('engagement_responses', function (Blueprint $table) {
52-
$table->dropIndex(['sender_type', 'sender_id', 'status']);
52+
$table->dropIndex(['sender_id', 'sender_type','status']);
5353
});
5454
}
5555
};

0 commit comments

Comments
 (0)