Skip to content

Commit e8acc1f

Browse files
committed
🐳 chore: Switched from system libc++ to V8 libc++ on Linux for V8 mode
1 parent f2ff345 commit e8acc1f

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

.github/workflows/linux_x86_64_build.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -61,13 +61,10 @@ jobs:
6161
cd ..
6262
gclient sync -D
6363
cd v8
64-
python3 tools/dev/v8gen.py x64.release -- v8_monolithic=true v8_use_external_startup_data=false is_component_build=false ${{ matrix.v8_flag }} v8_enable_pointer_compression=false v8_static_library=true symbol_level=0 use_custom_libcxx=false v8_enable_sandbox=false
65-
gn gen out.gn/x64.release
6664
sed -i '/#include "src\/libplatform\//a #include <cstdlib>' src/libplatform/default-thread-isolated-allocator.cc
6765
sed -i '/bool KernelHasPkruFix()/a const char* env = std::getenv("JAVET_DISABLE_PKU"); if (env && std::strlen(env) > 0) { return false; }' src/libplatform/default-thread-isolated-allocator.cc
68-
ninja -C out.gn/x64.release v8_monolith || python3 ${{ env.ROOT }}/Javet/scripts/python/patch_v8_build.py -p ./
69-
ninja -C out.gn/x64.release v8_monolith
70-
mv out.gn out.gn.${{ matrix.name }}
66+
gn gen out.gn.${{ matrix.name }}/x64.release --args='v8_monolithic=true v8_use_external_startup_data=false is_component_build=false ${{ matrix.v8_flag }} v8_enable_pointer_compression=false v8_static_library=true symbol_level=0 use_custom_libcxx=true v8_enable_sandbox=false'
67+
ninja -C out.gn.${{ matrix.name }}/x64.release v8_monolith
7168
7269
- name: Copy the i18n
7370
if: matrix.name == 'i18n'

docs/release_notes/release_notes_4_0.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ Release Notes 4.0.x - 4.1.x
88
* Upgraded Node.js to ``v22.14.0`` `(2025-02-11) <https://github.com/nodejs/node/blob/main/doc/changelogs/CHANGELOG_V22.md#22.14.0>`_
99
* Upgraded V8 to ``v13.5.212.10`` (2025-03-20)
1010
* Upgraded Visual Studio 2022 to `v17.13.5 <https://learn.microsoft.com/en-us/visualstudio/releases/2022/release-notes-v17.13>`_
11+
* Switched from system libc++ to V8 libc++ on Linux for V8 mode
1112
* Switched from MSVC to Clang on Windows for V8 mode
1213
* Moved float 16 detection to get better compatibility
1314
* Fixed improper lowercasing of method name for the proxy converter

0 commit comments

Comments
 (0)