Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make 'components' an explicit argument to render function #11

Open
caolan opened this issue Jan 15, 2018 · 1 comment
Open

Make 'components' an explicit argument to render function #11

caolan opened this issue Jan 15, 2018 · 1 comment
Assignees
@caolan

Comments

@caolan
Copy link
Owner

caolan commented Jan 15, 2018

Currently components reference each other via this, but that can be confusing (particularly when not explicitly calling a constructor in an OO style).

See #9 (comment) for an example of how this can easily cause confusion.
@caolan
Copy link
Owner Author

caolan commented Jan 21, 2018

Don't forget to also update the documentation and examples for this change.

@caolan caolan self-assigned this Jan 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caolan caolan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@caolan