feat(apps): support zip files in apps:builds:create --path option#148
Open
feat(apps): support zip files in apps:builds:create --path option#148
apps:builds:create --path option#148Conversation
Member
Author
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the apps:builds:create command to allow --path to accept either a source directory (zipped before upload) or a pre-built .zip file (uploaded directly), aligning the CLI’s build-source upload behavior more closely with the live updates flow.
Changes:
- Expand
--pathvalidation to accept either a directory (still requiringpackage.json) or a.zipfile. - When
--pathis a zip file, read and upload it directly (instead of re-zipping). - Switch path validation to use shared filesystem helpers (
fileExistsAtPath,isDirectory) and addcreateBufferFromPathusage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
--pathoption ofapps:builds:createnow accepts a local zip file in addition to a folder. When a zip file is provided, it is uploaded directly without re-zipping, matching the behavior ofapps:liveupdates:upload.package.json) or a.zipfile.createBufferFromPathand uploaded with its original filename preserved.zipFolderWithGitignoreflow is unchanged.