Find writeback registers#2960
Open
slate5 wants to merge 1 commit into
Open
Conversation
Detection of writebacks was only partially implemented: - MCInst_handleWriteback() was not called, so tied_op_idx was not filled - map_get_op_access() in RISCV_add_cs_detail_0() queried tied_op_idx unnecessarily, because all elements were -1 (initialization value)
Rot127
requested changes
Jun 9, 2026
Rot127
left a comment
Rot127
left a comment
Collaborator
There was a problem hiding this comment.
Please add the instruction which let you find the bug as test.
Contributor
Author
|
I didn't, i could run a lot of instructions in the hope of finding a discrepancy between manually setting RW access (as it was) and relying on auto-sync. I came across this accidentally, and i thought it's neater and more robust... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
Detection of writebacks was only partially implemented:
This uses auto-sync to find writebacks instead of having a custom function in arch/RISCV/
Test plan
...
Closing issues
...