Skip to content

Commit fdfe14f

Browse files
authored
Merge pull request #182 from carapace-sh/ecs-missing-flags
ecs: add missing flags
2 parents 4a807b5 + 34af32f commit fdfe14f

3 files changed

Lines changed: 26 additions & 2 deletions

File tree

cmd/carapace-aws/cmd/botocore/aws.ecs.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,7 @@ commands:
4848
--health-check-path=: The path on the container that the Application Load Balancer uses for health checks.
4949
--infrastructure-role-arn=!: The Amazon Resource Name (ARN) of the infrastructure role that grants Amazon ECS permission to create and manage Amazon Web Services resources on your behalf for the Express service.
5050
--memory=: The amount of memory (in MiB) used by the task.
51+
--monitor-mode=: Display mode for monitoring output
5152
--monitor-resources=: ' Enable live monitoring of service resource status'
5253
--network-configuration=: The network configuration for the Express service tasks.
5354
--primary-container=!: The primary container configuration for the Express service.
@@ -211,6 +212,7 @@ commands:
211212
--cli-input-json=: Read arguments from the JSON string provided.
212213
--cli-input-yaml=: Read arguments from the YAML string provided.
213214
--generate-cli-skeleton: Prints a JSON skeleton to standard output without sending an API request.
215+
--monitor-mode=: Display mode for monitoring output
214216
--monitor-resources=: ' Enable live monitoring of service resource status'
215217
--service-arn=!: The Amazon Resource Name (ARN) of the Express service to delete.
216218
- name: delete-service
@@ -634,6 +636,7 @@ commands:
634636
- name: monitor-express-gateway-service
635637
description: Monitors the progress of resource creation for an ECS Express Gateway Service
636638
flags:
639+
--mode=: Display mode for monitoring output
637640
--resource-view=: Specifies which resources to display during monitoring
638641
--service-arn=!: The short name or full Amazon Resource Name (ARN) of the service to monitor
639642
--timeout=: Maximum time in minutes to monitor the service. Default is 30 minutes
@@ -1019,7 +1022,8 @@ commands:
10191022
--generate-cli-skeleton: Prints a JSON skeleton to standard output without sending an API request.
10201023
--health-check-path=: The path on the container for Application Load Balancer health checks.
10211024
--memory=: The amount of memory (in MiB) used by the task.
1022-
--monitor-resources=: ' Enable live monitoring of service resource status'
1025+
--monitor-mode=: Display mode for monitoring output
1026+
--monitor-resources=: Enable live monitoring of service resource status
10231027
--network-configuration=: The network configuration for the Express service tasks.
10241028
--primary-container=: The primary container configuration for the Express service.
10251029
--scaling-target=: The auto-scaling configuration for the Express service.

cmd/carapace-spec-botocore/cmd/customizations/ecs.go

Lines changed: 16 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,14 +29,24 @@ func init() {
2929
}
3030

3131
customizations["ecs.update-express-gateway-service"] = func(cmd *command.Command) error {
32+
cmd.AddFlag(command.Flag{
33+
Longhand: "monitor-mode",
34+
Description: "Display mode for monitoring output",
35+
Value: true,
36+
})
3237
cmd.AddFlag(command.Flag{
3338
Longhand: "monitor-resources",
34-
Description: " Enable live monitoring of service resource status",
39+
Description: "Enable live monitoring of service resource status",
3540
Value: true,
3641
})
3742
return nil
3843
}
3944
customizations["ecs.delete-express-gateway-service"] = func(cmd *command.Command) error {
45+
cmd.AddFlag(command.Flag{
46+
Longhand: "monitor-mode",
47+
Description: "Display mode for monitoring output",
48+
Value: true,
49+
})
4050
cmd.AddFlag(command.Flag{
4151
Longhand: "monitor-resources",
4252
Description: " Enable live monitoring of service resource status",
@@ -45,6 +55,11 @@ func init() {
4555
return nil
4656
}
4757
customizations["ecs.create-express-gateway-service"] = func(cmd *command.Command) error {
58+
cmd.AddFlag(command.Flag{
59+
Longhand: "monitor-mode",
60+
Description: "Display mode for monitoring output",
61+
Value: true,
62+
})
4863
cmd.AddFlag(command.Flag{
4964
Longhand: "monitor-resources",
5065
Description: " Enable live monitoring of service resource status",

cmd/carapace-spec-botocore/cmd/customizations/ecs/aws.ecs.monitor-express-gateway-service.yaml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@
22
name: monitor-express-gateway-service
33
description: Monitors the progress of resource creation for an ECS Express Gateway Service
44
flags:
5+
--mode=: Display mode for monitoring output
56
--service-arn=!: The short name or full Amazon Resource Name (ARN) of the service to monitor
67
--resource-view=: Specifies which resources to display during monitoring
78
--timeout=: Maximum time in minutes to monitor the service. Default is 30 minutes
@@ -17,6 +18,10 @@ documentation:
1718
until manually stopped by the user or the specified timeout is reached. Use keyboard shortcuts to navigate:
1819
up/down to scroll through resources, ‘q’ to quit monitoring.
1920
flag:
21+
mode: |
22+
Display mode for monitoring output.
23+
INTERACTIVE (default if TTY available) - Real-time display with spinner and keyboard navigation.
24+
TEXT-ONLY - Text output with timestamps and change detection (works without TTY).
2025
service-arn: The short name or full Amazon Resource Name (ARN) of the service to monitor.
2126
resource-view: |
2227
Specifies which resources to display during monitoring.

0 commit comments

Comments
 (0)