Fish bridge not working

[TheCodeLamp]

Current Behavior

I have:

# bridges.yaml
zellij: fish

and CARAPACE_BRIDGES is set to fish,bash.

When I run carapace zellij nushell zellij - I get an empty list, however, when I run fish --command 'complete "--do-complete=zellij -"' I get the appropriate completions.

carapace --list --all --format json allows me to see that zellij is recognized as a bridge command.

Expected Behavior

I expect to get the same completions from the two commands if carapace actually use fish for it's bridge.

Steps To Reproduce

I have tried to make a spec file for zellij, but this didn't work. I have tried to use a different shell (bash), but this didn't work.

Version

1.5.7

OS

• Darwin
• Linux
• Termux
• Windows

Shell

• Bash
• Elvish
• Fish
• Nushell
• Oil
• Powershell
• Xonsh
• Zsh

Anything else?

The fish completion file, located at .config/fish/completions/zellij.fish, is generated by the command zellij setup --generate-completion fish.

[rsteube]

Installed zellij and the fish -> nushell bridge of it seems fine.
Which fish version are you using?

[rsteube]

Version 4.2.1 works fine, somethings changed in 4.3.0 that breaks it.

[TheCodeLamp]

Right now I'm really confused. I tried making an arch distrobox container to test different versions.

My main machine is a fedora machine. The versions I have here are:

$ carapace --version
carapace-bin 1.5.7
$ fish --version
fish, version 4.2.0
$ zellij --version
zellij 0.43.1
$ nu --version
0.99.1

I have tried running the command CARAPACE_BRIDGES=fish carapace zellij nushell zellij - both in nushell and in bash, but both return an empty list.

In the arch container I have downgraded the versions using the arch archive. They now reflect the main machine:

[arch]$ carapace --version
carapace-bin 1.5.7
[arch]$ fish --version
fish, version 4.2.0
[arch]$ zellij --version
zellij 0.43.1
[arch]$ nu --version
0.99.1

However, when I run the command inside this container I get a proper output:

[arch]$ CARAPACE_BRIDGES=fish carapace zellij nushell zellij -
[{"value":"--config ","display":"--config","description":"Change where zellij looks for the configuration file"}......etc.

It even works when using nushell.

It even worked when using fish version 4.3.1, so the issue you had @rsteube might have been fixed.

I am unsure where to look for next. Is there a way to emit tracing logs for carapace so that I can check where the issue might exist?

[rsteube]

I am unsure where to look for next. Is there a way to emit tracing logs for carapace so that I can check where the issue might exist?

There's CARAPACE_LOG which writes some logs to your tempdir, but not sure if it helps.

[rsteube]

The zellij completion just doesn't work for me in fish 4.3+ itself. I just dowloaded the binary (not a package install), the completion script of zellij is probably just not being loaded.

[theherk]

Actually, I've just noticed that any variable expansion in command arguments no longer works for me in fish. For instance if I have a variable with a path I can't autocomplete.

set -gx P $HOME/projects
cat $P/<tab> # NOGO

Maybe related?

[TheCodeLamp]

I have found the issue.

The command run by carapace is essentially this:

set __fish_config_dir /var/empty

source "$__fish_data_dir/config.fish"
source "~/.config/carapace/bridge/fish/config.fish"

complete --do-complete="zellij -"

And it's run using fish --no-config. For some reason this makes it so that ~/.config/fish/completions aren't sourced.

I have fixed this issue by adding this to ~/.config/carapace/bridge/fish/config.fish:

for f in ~/.config/fish/completions/*.fish
    [ -f "$f" ]; and source "$f"
end

This has allowed the zellij completions to run without issue.

I don't know if this is a issue that can be fixed in carapace, so I'll leave the issue open.

[rsteube]

Actually, I've just noticed that any variable expansion in command arguments no longer works for me in fish.

Variable expansion is currently not supported.

And it's run using fish --no-config. For some reason this makes it so that ~/.config/fish/completions aren't sourced.

The default fish config not sourced for performance reasons (and to avoid a loop).
Might make sense to reconsider the completions folder itself if it can be sourced lazily.

https://github.com/carapace-sh/carapace-bridge/blob/master/pkg/bridges/fish.go#L29
https://github.com/carapace-sh/carapace-bridge/blob/master/pkg/actions/bridge/fish.go#L33