Skip to content

Add kitten completer#3281

Merged
rsteube merged 45 commits intocarapace-sh:masterfrom
steschwa:kitten-completer
Mar 17, 2026
Merged

Add kitten completer#3281
rsteube merged 45 commits intocarapace-sh:masterfrom
steschwa:kitten-completer

Conversation

@steschwa
Copy link
Contributor

Completer for the kitty terminals kitten commands: https://sw.kovidgoyal.net/kitty/kittens_intro/

@rsteube
Copy link
Member

rsteube commented Feb 21, 2026

Lots of the commands have AddCommand inverted and I'm getting no completions out of it.

-	lsCmd.AddCommand(atCmd)
+	atCmd.AddCommand(lsCmd)

@rsteube
Copy link
Member

rsteube commented Feb 26, 2026

Commands without a Run function are ignored by cobra which is why there was no completion of the subcommands.
You can build and test it like this: https://carapace-sh.github.io/carapace-bin/development/build.html#development

Comparing the completions with the bridged (native) ones is also possible:

carapace --diff kitten/kitten kitten ...

They don't necesarily need to be the same though. Native completions often lack specific flags or there are opiniated differences.

@rsteube rsteube merged commit c631a6a into carapace-sh:master Mar 17, 2026
4 checks passed
@steschwa steschwa deleted the kitten-completer branch March 18, 2026 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants