@@ -121,12 +121,20 @@ func TestJoin(t *testing.T) {
121121 for expected , words := range map [string ][]string {
122122 `` : {},
123123 `echo "\$(ls)"` : {"echo" , "$(ls)" },
124- "echo \" \\ `ls\\ `\" " : {"echo" , "`ls`" },
125124 "echo \" 'ls'\" " : {"echo" , "'ls'" },
126125 `echo "\"ls\""` : {"echo" , `"ls"` },
127126 `echo "\$(ls /tmp)"` : {"echo" , "$(ls /tmp)" },
127+ "echo \" \\ `ls\\ `\" " : {"echo" , "`ls`" },
128128 `ls /tmp | xargs -n 1 echo` : {"ls" , "/tmp" , "|" , "xargs" , "-n" , "1" , "echo" },
129- `echo "one\ntwo"` : {"echo" , "one\n two" },
129+
130+ `echo "with\"doubleQuote"` : {"echo" , "with\" doubleQuote" },
131+ `echo "with'singleQuote"` : {"echo" , "with'singleQuote" },
132+ `echo "with space"` : {"echo" , "with space" },
133+ "echo \" with\\ `backtick\" " : {"echo" , "with`backtick" },
134+ `echo "with\$dollar"` : {"echo" , "with$dollar" },
135+ `echo "with\nlinefeed"` : {"echo" , "with\n linefeed" },
136+ `echo "with\rcarriageReturn"` : {"echo" , "with\r carriageReturn" },
137+ `echo "with\ttab"` : {"echo" , "with\t tab" },
130138 } {
131139 if actual := Join (words ); actual != expected {
132140 t .Errorf ("joined words don't match\n actual : %#v\n expected: %#v" , actual , expected )
0 commit comments