fix more hints

Author: rsteube

third_party/github.com/drone/envsubst/template.go

@@ -3,7 +3,7 @@ package envsubst
 import (
 	"bytes"
 	"io"
-	"io/ioutil"
+	"os"
 
 	"github.com/carapace-sh/carapace/third_party/github.com/drone/envsubst/parse"
 )
@@ -38,7 +38,7 @@ func Parse(s string) (t *Template, err error) {
 // ParseFile creates a new shell format template and parses the template
 // definition from the named file.
 func ParseFile(path string) (*Template, error) {
-	b, err := ioutil.ReadFile(path)
+	b, err := os.ReadFile(path)
 	if err != nil {
 		return nil, err
 	}

third_party/github.com/hexops/gotextdiff/diff.go

@@ -132,11 +132,9 @@ func addEdit(before string, edits []TextEdit, edit TextEdit) []TextEdit {
 	if start.Offset() >= len(before) && start.Line() > 1 && before[len(before)-1] != '\n' {
 		// after end of file that does not end in eol, so join to last line of file
 		// to do this we need to know where the start of the last line was
-		eol := strings.LastIndex(before, "\n")
-		if eol < 0 {
+		eol := max(strings.LastIndex(before, "\n"),
 			// file is one non terminated line
-			eol = 0
-		}
+			0)
 		delta := len(before) - eol
 		start = span.NewPoint(start.Line()-1, 1, start.Offset()-delta)
 		edit.Span = span.New(edit.Span.URI(), start, end)

third_party/github.com/mitchellh/go-ps/process_freebsd.go

@@ -187,7 +187,7 @@ func processes() ([]Process, error) {
 	count := int(length / uint64(procinfo_len))
 
 	// parse buf to procs
-	for i := 0; i < count; i++ {
+	for i := range count {
 		b := buf[i*procinfo_len : i*procinfo_len+procinfo_len]
 		k, err := parse_kinfo_proc(b)
 		if err != nil {

third_party/github.com/mitchellh/go-ps/process_solaris.go

@@ -87,7 +87,7 @@ func (p *UnixProcess) Refresh() error {
 }
 
 func toString(array []byte, len int) string {
-	for i := 0; i < len; i++ {
+	for i := range len {
 		if array[i] == 0 {
 			return string(array[:i])
 		}