Merge pull request #768 from rsteube/no_color

support NO_COLOR env

Author: rsteube

context.go

@@ -8,6 +8,7 @@ import (
 	"strings"
 
 	"github.com/rsteube/carapace/internal/common"
+	"github.com/rsteube/carapace/internal/env"
 	"github.com/rsteube/carapace/internal/shell/zsh"
 	"github.com/rsteube/carapace/third_party/github.com/drone/envsubst"
 	"github.com/rsteube/carapace/third_party/golang.org/x/sys/execabs"
@@ -46,9 +47,9 @@ func NewContext(args ...string) Context {
 	}
 
 	isGoRun := func() bool { return strings.HasPrefix(os.Args[0], os.TempDir()+"/go-build") }
-	if value, exists := os.LookupEnv("CARAPACE_SANDBOX"); exists && isGoRun() {
+	if sandbox := env.Sandbox(); sandbox != "" && isGoRun() {
 		var m common.Mock
-		_ = json.Unmarshal([]byte(value), &m)
+		_ = json.Unmarshal([]byte(sandbox), &m)
 		context.Dir = m.Dir
 		context.mockedReplies = m.Replies
 	}

internal/common/value.go

@@ -82,6 +82,16 @@ func (r RawValues) Filter(values ...string) RawValues {
 	return filtered
 }
 
+// Decolor clears style for all values.
+func (r RawValues) Decolor() RawValues {
+	rawValues := make(RawValues, len(r))
+	for index, value := range r {
+		value.Style = ""
+		rawValues[index] = value
+	}
+	return rawValues
+}
+
 // FilterPrefix filters values with given prefix.
 func (r RawValues) FilterPrefix(prefix string) RawValues {
 	filtered := make(RawValues, 0)

internal/config/env.go

@@ -0,0 +1,23 @@
+package env
+
+import "os"
+
+func ColorDisabled() bool {
+	return os.Getenv("NO_COLOR") != "" || os.Getenv("CLICOLOR") == "0"
+}
+
+func Lenient() bool {
+	return os.Getenv("CARAPACE_LENIENT") != ""
+}
+
+func Hashdirs() string {
+	return os.Getenv("CARAPACE_ZSH_HASH_DIRS")
+}
+
+func Sandbox() string {
+	return os.Getenv("CARAPACE_SANDBOX")
+}
+
+func Log() bool {
+	return os.Getenv("CARAPACE_LOG") != ""
+}

internal/env/env.go

@@ -6,6 +6,7 @@ import (
 	"strings"
 
 	"github.com/rsteube/carapace/internal/common"
+	"github.com/rsteube/carapace/internal/env"
 	"github.com/rsteube/carapace/internal/shell/bash"
 	"github.com/rsteube/carapace/internal/shell/bash_ble"
 	"github.com/rsteube/carapace/internal/shell/elvish"
@@ -20,6 +21,7 @@ import (
 	"github.com/rsteube/carapace/internal/shell/xonsh"
 	"github.com/rsteube/carapace/internal/shell/zsh"
 	"github.com/rsteube/carapace/pkg/ps"
+	"github.com/rsteube/carapace/pkg/style"
 	"github.com/spf13/cobra"
 )
 
@@ -71,6 +73,13 @@ func Value(shell string, value string, meta common.Meta, values common.RawValues
 		"zsh":        zsh.ActionRawValues,
 	}
 	if f, ok := shellFuncs[shell]; ok {
+		if env.ColorDisabled() {
+			style.Carapace.Value = style.Default
+			style.Carapace.Description = style.Default
+			style.Carapace.Error = style.Underlined
+			style.Carapace.Usage = style.Italic
+			values = values.Decolor()
+		}
 		filtered := values.FilterPrefix(value)
 		switch shell {
 		case "elvish", "export", "zsh": // shells with support for showing messages

internal/shell/shell.go

@@ -1,8 +1,9 @@
 package zsh
 
 import (
-	"os"
 	"strings"
+
+	"github.com/rsteube/carapace/internal/env"
 )
 
 type namedDirectories map[string]string
@@ -34,7 +35,7 @@ func (nd *namedDirectories) Replace(s string) string {
 }
 
 func init() {
-	if hashDirs, ok := os.LookupEnv("CARAPACE_ZSH_HASH_DIRS"); ok {
+	if hashDirs := env.Hashdirs(); hashDirs != "" {
 		for _, line := range strings.Split(hashDirs, "\n") {
 			if splitted := strings.SplitN(line, "=", 2); len(splitted) == 2 {
 				NamedDirectories[splitted[0]] = splitted[1]

internal/shell/zsh/namedDirectory.go

@@ -6,14 +6,15 @@ import (
 	"log"
 	"os"
 
+	"github.com/rsteube/carapace/internal/env"
 	"github.com/rsteube/carapace/internal/uid"
 	"github.com/rsteube/carapace/pkg/ps"
 )
 
 var LOG = log.New(ioutil.Discard, "", log.Flags())
 
 func init() {
-	if _, enabled := os.LookupEnv("CARAPACE_LOG"); !enabled {
+	if !env.Log() {
 		return
 	}
 

log.go

@@ -4,7 +4,7 @@ import (
 	"strings"
 
 	"github.com/rsteube/carapace/internal/common"
-	"github.com/rsteube/carapace/internal/config"
+	"github.com/rsteube/carapace/internal/env"
 	"github.com/rsteube/carapace/internal/pflagfork"
 	"github.com/rsteube/carapace/pkg/style"
 	"github.com/spf13/cobra"
@@ -39,7 +39,7 @@ func traverse(c *cobra.Command, args []string) (Action, Context) {
 	LOG.Printf("traverse called for %#v with args %#v\n", c.Name(), args)
 	storage.preRun(c, args)
 
-	if config.IsLenient() {
+	if env.Lenient() {
 		LOG.Printf("allowing unknown flags")
 		c.FParseErrWhitelist.UnknownFlags = true
 	}