Merge pull request #1862 from carbon-design-system/fix-barchart-null

fix(barchart): handle null values

Author: tay1orjones

src/components/BarChartCard/barChartUtils.js

@@ -105,7 +105,7 @@ export const formatChartData = (
   type
 ) => {
   const data = [];
-  if (!isNil(values) || !isEmpty(series)) {
+  if (!isNil(values) && !isEmpty(series)) {
     // grouped or stacked
     if (type === BAR_CHART_TYPES.GROUPED || type === BAR_CHART_TYPES.STACKED) {
       let uniqueDatasetNames;
@@ -151,7 +151,7 @@ export const formatChartData = (
         });
       });
     } // single bars and not time-based
-    else if (categoryDataSourceId) {
+    else if (categoryDataSourceId && Array.isArray(values)) {
       const uniqueDatasetNames = [
         ...new Set(values.map((val) => val[categoryDataSourceId])),
       ];
@@ -171,7 +171,7 @@ export const formatChartData = (
         });
       });
     } // single bars and time-based
-    else {
+    else if (Array.isArray(values)) {
       const uniqueDatasetNames = [
         ...new Set(values.map((val) => val[timeDataSourceId])),
       ];

src/components/BarChartCard/barChartUtils.test.js

@@ -147,6 +147,19 @@ describe('barChartUtils', () => {
     });
   });
 
+  it('formatChartData handles null values', () => {
+    const series = [
+      {
+        dataSourceId: 'particles',
+        label: 'Particles',
+      },
+    ];
+    // check horizontal layout
+    expect(
+      formatChartData(series, null, 'city', null, BAR_CHART_TYPES.GROUPED)
+    ).toEqual([]);
+  });
+
   it('formatChartData returns formatted data for group-based chart', () => {
     const series = [
       {