Skip to content

Commit dd53c53

Browse files
Merge pull request #1936 from carbon-design-system/hide-value-settings
fix(dashboardeditor): hide value card font size setting
2 parents 30577c2 + a039c77 commit dd53c53

2 files changed

Lines changed: 18 additions & 358 deletions

File tree

src/components/CardEditor/CardEditForm/CardEditForm.jsx

Lines changed: 18 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -261,19 +261,24 @@ const CardEditForm = ({
261261
onFetchDynamicDemoHotspots={onFetchDynamicDemoHotspots}
262262
/>
263263
</Tab>
264-
<Tab label={mergedI18n.settingsTabLabel}>
265-
<CardEditFormSettings
266-
availableDimensions={availableDimensions}
267-
cardConfig={
268-
cardConfig.type === CARD_TYPES.CUSTOM
269-
? { ...omit(cardConfig, 'content') }
270-
: cardConfig
271-
}
272-
onChange={onChange}
273-
i18n={mergedI18n}
274-
getValidDataItems={getValidDataItems}
275-
/>
276-
</Tab>
264+
{
265+
// Hide value card form settings until font size option is functional
266+
cardConfig.type !== CARD_TYPES.VALUE ? (
267+
<Tab label={mergedI18n.settingsTabLabel}>
268+
<CardEditFormSettings
269+
availableDimensions={availableDimensions}
270+
cardConfig={
271+
cardConfig.type === CARD_TYPES.CUSTOM
272+
? { ...omit(cardConfig, 'content') }
273+
: cardConfig
274+
}
275+
onChange={onChange}
276+
i18n={mergedI18n}
277+
getValidDataItems={getValidDataItems}
278+
/>
279+
</Tab>
280+
) : null
281+
}
277282
</Tabs>
278283
<div className={`${baseClassName}--footer`}>
279284
<Button

0 commit comments

Comments
 (0)