fix(button): omit href when disabled to avoid invalid <button href>

Author: metonym

src/Button/Button.svelte

@@ -152,7 +152,7 @@
     type: href && !disabled ? undefined : type,
     tabindex,
     disabled: disabled === true ? true : undefined,
-    href,
+    href: href && !disabled ? href : undefined,
     "aria-pressed":
       hasIconOnly && kind === "ghost" && !href ? isSelected : undefined,
     ...$$restProps,

tests/Button/Button.test.svelte

@@ -34,6 +34,10 @@
 
 <Button disabled>Disabled button</Button>
 
+<Button data-testid="btn-disabled-href" href="#" disabled>
+  Disabled link button
+</Button>
+
 <Button icon={Add}>With icon</Button>
 
 <Button

tests/Button/Button.test.ts

@@ -80,6 +80,15 @@ describe("Button", () => {
     expect(disabledButton).toHaveClass("bx--btn--disabled");
   });
 
+  it("should strip href when disabled is also set", () => {
+    render(Button);
+
+    const button = screen.getByTestId("btn-disabled-href");
+    expect(button.tagName).toBe("BUTTON");
+    expect(button).toBeDisabled();
+    expect(button).not.toHaveAttribute("href");
+  });
+
   it("should render skeleton state", () => {
     render(Button);