Skip to content

Commit ce6686c

Browse files
authored
fix(percy): add global waitForSelector to validate that storybook has loaded (#7483)
* fix(percy): increase network timeout value * fix: lower timeout to max allowed value * refactor: wait for sb to load before taking snapshot * fix: percy waitForSelector needs to be string
1 parent b182746 commit ce6686c

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

.percy.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,13 @@ snapshot:
66
- 1366
77
minHeight: 1024
88
discovery:
9-
network_idle_timeout: 500
9+
network_idle_timeout: 750
1010
storybook:
11+
waitForTimeout: 1000
12+
# waits for data-carbon-theme attribute to exist before taking snapshot
13+
# if storybook is still loading, percy could take a snapshot of the storybook
14+
# loading spinner and cause flaky tests
15+
waitForSelector: '[data-carbon-theme]'
1116
include: ['/IBM Products/']
1217
exclude: [
1318
'/Internal/',

0 commit comments

Comments
 (0)