Skip to content

Android fill value issues in texture mode #107

@Shane98c

Description

@Shane98c

Testing on a pixel 6a with latest chrome (also reproducible on firefox for android):

  • fill value of 9.969209968386869e36 is not being discarded and instead rendered as a very large number
  • maps/src/shaders.js

    Lines 152 to 154 in b9782db

    if (${vars[0]} == fillValue) {
    discard;
    }
  • based on debugging it looks like the fill value is being treated as at least an order of mag larger number than it is, we were able to extract the expected fill value using the region picker, so the issue appears to be in the fragment shader.
  • Reproduced in prototype-maps https://github.com/carbonplan/prototype-maps (issue initially noticed in https://github.com/carbonplan/oae-web).
  • Also tested with toggling forest-carbon viewer to use 'texture' and saw initial flash of the issue, soon corrected by

yellow areas are the fillValue areas, continent interiors are manually filled with zeros in the below screenshot.
image

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions