driver_executable_path seems not to be respected, redownloads every instance (original undetected_chromedriver version respects driver_executable_path)

[bayanwatch1]

import undetected as uc
import logging

logging.basicConfig(level=logging.DEBUG)

options = uc.ChromeOptions()

# Enable network/performance logging
options.set_capability(
    "goog:loggingPrefs",
    {"performance": "ALL"}
)

driver = uc.Chrome(
    options=options,

    driver_executable_path="./bin/chromedriver-linux64/chromedriver",
    use_subprocess=False
)

driver.get("https://example.com")
driver.quit()

DEBUG:undetected.patcher:Cleaning up unused files; found: []
DEBUG:undetected.patcher:getting release number from /latest-versions-per-milestone-with-downloads.json

It then gets stuck presumably downloading the chromedriver executable for god knows how long. It's been at it for like 15 minutes.

Need to have the webdriver cached as it takes a while for it to download and execute the actual reqquest

[carl0smat3us]

import undetected as uc
import logging

logging.basicConfig(level=logging.DEBUG)

options = uc.ChromeOptions()

Enable network/performance logging

options.set_capability(
"goog:loggingPrefs",
{"performance": "ALL"}
)

driver = uc.Chrome(
options=options,

driver_executable_path="./bin/chromedriver-linux64/chromedriver",
use_subprocess=False

)

driver.get("https://example.com")
driver.quit()

DEBUG:undetected.patcher:Cleaning up unused files; found: []
DEBUG:undetected.patcher:getting release number from /latest-versions-per-milestone-with-downloads.json

It then gets stuck presumably downloading the chromedriver executable for god knows how long. It's been at it for like 15 minutes.

Need to have the webdriver cached as it takes a while for it to download and execute the actual reqquest

why are you using the parameter driver_executable_path?

[carl0smat3us]

import undetected as uc
import logging

logging.basicConfig(level=logging.DEBUG)

options = uc.ChromeOptions()

Enable network/performance logging

options.set_capability(
"goog:loggingPrefs",
{"performance": "ALL"}
)

driver = uc.Chrome(
options=options,

driver_executable_path="./bin/chromedriver-linux64/chromedriver",
use_subprocess=False

)

driver.get("https://example.com")
driver.quit()

DEBUG:undetected.patcher:Cleaning up unused files; found: []
DEBUG:undetected.patcher:getting release number from /latest-versions-per-milestone-with-downloads.json

It then gets stuck presumably downloading the chromedriver executable for god knows how long. It's been at it for like 15 minutes.

Need to have the webdriver cached as it takes a while for it to download and execute the actual reqquest

you don't really need to use it anymore,

did you try without using it?

explain me more...

[bayanwatch1]

did you try without using it?

explain me more...

The reason is that all chromedrivers download the latest version which takes a while, about 15 minutes which is dependent on shoddy internet speed. It's pretty annoying when you have to debug and you have to wait for 15 minutes in order for the code to actually execute. I don't think anyone would code with something that takes 30 minutes to execute. At least allow the user to cache the patched webdriver, and disable the auto update.

DEBUG:undetected.patcher:Cleaning up unused files; found: [PosixPath('/home/user/.local/share/undetected/d41cc92ed1725d01_chromedriver')]
DEBUG:undetected.patcher:Killed running instances of /home/user/.local/share/undetected/d41cc92ed1725d01_chromedriver
DEBUG:undetected.patcher:Deleted chromedriver: /home/user/.local/share/undetected/d41cc92ed1725d01_chromedriver
DEBUG:undetected.patcher:getting release number from /latest-versions-per-milestone-with-downloads.json

[carl0smat3us]

did you try without using it?
explain me more...

The reason is that all chromedrivers download the latest version which takes a while, about 15 minutes which is dependent on shoddy internet speed. It's pretty annoying when you have to debug and you have to wait for 15 minutes in order for the code to actually execute. I don't think anyone would code with something that takes 30 minutes to execute. At least allow the user to cache the patched webdriver, and disable the auto update.

DEBUG:undetected.patcher:Cleaning up unused files; found: [PosixPath('/home/user/.local/share/undetected/d41cc92ed1725d01_chromedriver')]
DEBUG:undetected.patcher:Killed running instances of /home/user/.local/share/undetected/d41cc92ed1725d01_chromedriver
DEBUG:undetected.patcher:Deleted chromedriver: /home/user/.local/share/undetected/d41cc92ed1725d01_chromedriver
DEBUG:undetected.patcher:getting release number from /latest-versions-per-milestone-with-downloads.json

hold on, before jumping into conclusions

[bayanwatch1]

I've removed the driver_executable_path and it still takes AGES for it to download. Did you remove the functionality for caching? I think it is not beneficial for it to be removed as it doesn't help with code development when you have to wait 15-30 m for the client to launch

When I used the original ultrafunk module you forked this repo one function I really loved was that you could cache the executable. This sped up how much you work with the code and debugging. I work with cloudflare protected websites at the moment that are in risk of deletion so it might need to be fixed in the latest time you are most comfortable.

DEBUG:undetected.patcher:Cleaning up unused files; found: []
DEBUG:undetected.patcher:getting release number from /latest-versions-per-milestone-with-downloads.json

[carl0smat3us]

I've removed the driver_executable_path and it still takes AGES for it to download. Did you remove the functionality for caching? I think it is not beneficial for it to be removed as it doesn't help with code development when you have to wait 15-30 m for the client to launch

When I used the original ultrafunk module you forked this repo one function I really loved was that you could cache the executable. This sped up how much you work with the code and debugging. I work with cloudflare protected websites at the moment that are in risk of deletion so it might need to be fixed in the latest time you are most comfortable.

DEBUG:undetected.patcher:Cleaning up unused files; found: []
DEBUG:undetected.patcher:getting release number from /latest-versions-per-milestone-with-downloads.json

i'll do some testing on my side

[carl0smat3us]

are you sure you are using the latest version?

[carl0smat3us]

Now I can see better what you talking about,

Once I have time
I'll see what I can do

[bayanwatch1]

are you sure you are using the latest version?

yes, I installed it today from pip install undetected I assume i might have to retry with the git clone install

[carl0smat3us]

i have a full explanation for it.

[carl0smat3us]

basically its going to delete allways the patched drive to avoid issues

[carl0smat3us]

Honestly, it's only deleting the patched driver, not the unpatched one. I don't fully remember, but I think the original library had issues managing multiple copies of patched drivers.

So to solve It would be a good option to check for an existing unpatched driver in the temp directory or any other before patching a new one, instead of doing this

def fetch_package(self):
zip_name = f"chromedriver_{self.platform_name}.zip"

    if self.is_old_chromedriver:
        download_url = "%s/%s/%s" % (
            self.url_repo,
            str(self.version_full),
            zip_name,
        )
    else:
        zip_name = zip_name.replace("_", "-", 1)
        download_url = (
            "https://storage.googleapis.com/chrome-for-testing-public/%s/%s/%s"
        )
        download_url %= (str(self.version_full), self.platform_name, zip_name)

    logger.debug("downloading from %s" % download_url)

    with tempfile.NamedTemporaryFile(delete=False, suffix=".zip") as tmp_file:
        tmp_path = Path(tmp_file.name)
        with urlopen(download_url, context=self.ssl_ctx) as response:
            tmp_file.write(response.read())

    return str(tmp_path)

[bayanwatch1]

Would it be beneficial to have a flag to not redownload + patch every execution + storage of cache? Sounds inconvenient and borderline unusable to have the module redownload every time, wasting 15 minutes.

[carl0smat3us]

Would it be beneficial to have a flag to not redownload + patch every execution + storage of cache? Sounds inconvenient and borderline unusable to have the module redownload every time, wasting 15 minutes.

I agree but it really never took more than 5 seconds on my side

[bayanwatch1]

I agree but it really never took more than 5 seconds on my side

well not everyone has your internet speed. Australia has worse speeds than we currently have and maybe someone cant download things within 5 second interval . Doesn't it hurt to at least add some basic caching functionality maybe? Not everyone has 100Gbps of internet speed and it only takes maybe like less than 3 days to implement in code but it saves everyone from doing this. It's pointless and inefficient to call a download per execution it doesnt make any sort of sense to me. It's a simple boolean flag at the very least, how can that hurt anyone? As i said not everyone who uses this module has blazing fast internet so it makes absolutely no sense to not add it in the main module. Its like trying to constantly argue against ramps when you have people with wheelchairs coming by it doesnt hurt to add something that helps everyone in the long term