Version 3.0.0: Major naming updates

Updating the variable naming of the generated datatypes from CamelCase
to under_score_case and some other naming conventions. These are
interface braking changes, therefore updating to 3.0.0
Providing basic renaming script that covers for many of the changes.

Building:
- support gcc-13 and Ubuntu 24.04
- support newer spdlog: adding formatters for datatype logging
- remove spdlog submodule to make use of system delivered version
- Harmonize CXX standard to 17
- update BUILDING.md on how to work with python venv (enforced with
Ubunut 24.04)
- fix python binding build and test

Generated DataTypes:
introduced more safe datatype operations by restricting their values to
the limits after the operations
allow automatic conversion of datatypes to their basetypes with
"operator double()" if explicit type conversion is disabled

added ad::geometry namespace and library

added some ad::physics operations

ad_map_access:
- extended and hardened route/routing and predictions operations
- added support for qgis correction functions
- Added route::planning::predictRoutes* overloads which already provide
the object yaw via the object data to get rid of extra calculation
efforts
- Fix getLaneENUHeading(match::MapMatchedPosition): set correct geo
reference, otherwise returned heading is wrong
- Add Heading constants
- Add allowedObjectDistanceToLane to getMapMatchedBoundingBox()
- Add ad::map::geometry namespace with polygon operations and extraction
of occluded regions
- Allow getLateralAlignementEdge() for physics::RatioValue
- Fix ad::map::route::findWaypoint( distance == 0., route)
- Added match:getENUBorder(LaneOccupiedRegion) function
- Added point::getUnion(BoundingSphere, BoundingSphere) for use in
python
- Allow shortenRouteToDistance to cut intersections on request

ad_map_access_qgis:
- add polygon operations
- remove unused partition manager
- add lane correction abilities
- add lane contact correction abilities
- add traffic light layer
- add ClickedPoint debug output and support altitude unknown matching
- Support default intersection contact creation on adm load
- Add support for exporting adm files

Author: Bernd Gassmann

.github/workflows/code_format_check.yml

@@ -1,4 +1,4 @@
-name: Check Code Formatting for AD-Map Library
+name: Check Code Formatting for carla-map libraries
 
 on:
   push:
@@ -11,7 +11,7 @@ permissions:
 
 jobs:
   check_cpp:
-
+ 
     name: Check Code Formatting
 
     runs-on: ubuntu-22.04

.gitignore

@@ -3,3 +3,5 @@
 /log/
 __pycache__/
 *\.pyc
+ad_map_access/tests/test_files/Town01.adm.txt
+

.gitmodules

@@ -1,6 +1,3 @@
-[submodule "dependencies/spdlog"]
-	path = dependencies/spdlog
-	url = https://github.com/gabime/spdlog.git
 [submodule "dependencies/odrSpiral"]
 	path = dependencies/odrSpiral
 	url = https://github.com/DLR-TS/odrSpiral

README.md

@@ -66,16 +66,19 @@ To download the library, you may run:
 ```
 
 #### Supported systems <a name="systems"></a>
-Development system is Ubuntu 22.04
+Development systems are Ubuntu 22.04 and 24.04 
 Following compiler and Python combinations are [tested continously](.github/workflows/build_test.yml):
 
-|                 | Ubuntu 22.04 |
-|:---------------:|:------------:|
-|   GCC 11        |       x      |
-|  Clang 14       |       x      |
-|  Python 3.10    |       x      |
+|                 | Ubuntu 22.04 | Ubuntu 24.04 |
+|:---------------:|:------------:|:------------:|
+|   GCC 11        |       x      |              |
+|   GCC 13        |              |       x      |
+|  Clang 14       |       x      |              |
+|  Clang 18       |              |       x      |
+|  Python 3.10    |       x      |              |
+|  Python 3.12    |              |       x      |
 
-Important: cmake is required to be at least version 3.5!
+Important: cmake is required to be at least version 3.10!
 
 ## Building the library <a name="building"></a>
 See the detailed [Build instructions](https://ad-map-access.readthedocs.io/en/latest/BUILDING/index.html).

ad_map_access/CMakeLists.txt

@@ -39,7 +39,7 @@ find_package(ad_map_opendrive_reader ${CARLA-MAP_VERSION} EXACT REQUIRED CONFIG)
 find_package(ad_physics ${CARLA-MAP_VERSION} EXACT REQUIRED CONFIG)
 find_package(spdlog REQUIRED CONFIG)
 
-include(generated/ad_map_access.cmake)
+file(GLOB_RECURSE ad_map_access_GENERATED_SOURCES "${CMAKE_CURRENT_LIST_DIR}/generated/*.cpp")
 
 add_library(${PROJECT_NAME}
   ${ad_map_access_GENERATED_SOURCES}
@@ -51,19 +51,19 @@ add_library(${PROJECT_NAME}
   ${CMAKE_CURRENT_SOURCE_DIR}/src/access/Store.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/access/StoreSerialization.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/config/MapConfigFileHandler.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/src/geometry/PolygonOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/intersection/CoreIntersection.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/intersection/Intersection.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/landmark/LandmarkOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/lane/BorderOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/lane/LaneOperation.cpp
+  ${CMAKE_CURRENT_SOURCE_DIR}/src/lane/MapAreaOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/match/AdMapMatching.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/match/MapMatchedOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/opendrive/AdMapFactory.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/opendrive/DataTypeConversion.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/point/BoundingSphereOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/point/CoordinateTransform.cpp
-  ${CMAKE_CURRENT_SOURCE_DIR}/src/point/ECEFOperation.cpp
-  ${CMAKE_CURRENT_SOURCE_DIR}/src/point/ENUOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/point/GeometryOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/point/GeoOperation.cpp
   ${CMAKE_CURRENT_SOURCE_DIR}/src/point/HeadingOperation.cpp
@@ -149,6 +149,7 @@ install(FILES
 # Tests
 #####################################################################
 if (BUILD_TESTING)
+  add_subdirectory(test_support)
   add_subdirectory(tests)
 endif()
 

ad_map_access/cmake/Version.hpp.in

@@ -12,7 +12,7 @@
  * Generated file
  * @file
  *
- * Generator Version : 11.0.0-1997
+ * Generator Version : 11.0.0-2046
  */
 
 #pragma once

ad_map_access/generated/ad_map_access.cmake

@@ -1,7 +1,7 @@
 /*
  * ----------------- BEGIN LICENSE BLOCK ---------------------------------
  *
- * Copyright (C) 2018-2020 Intel Corporation
+ * Copyright (C) 2018-2022 Intel Corporation
  *
  * SPDX-License-Identifier: MIT
  *
@@ -12,7 +12,7 @@
  * Generated file
  * @file
  *
- * Generator Version : 11.0.0-1997
+ * Generator Version : 11.0.0-2046
  */
 
 #pragma once
@@ -22,6 +22,9 @@
 #include <limits>
 #include <memory>
 #include <sstream>
+#include "spdlog/fmt/ostr.h"
+#include "spdlog/spdlog.h"
+
 /*!
  * @brief namespace ad
  */
@@ -99,8 +102,8 @@ struct GeometryStoreItem
    */
   bool operator==(const GeometryStoreItem &other) const
   {
-    return (leftEdgeOffset == other.leftEdgeOffset) && (rightEdgeOffset == other.rightEdgeOffset)
-      && (leftEdgePoints == other.leftEdgePoints) && (rightEdgePoints == other.rightEdgePoints);
+    return (left_edge_offset == other.left_edge_offset) && (right_edge_offset == other.right_edge_offset)
+      && (left_edge_points == other.left_edge_points) && (right_edge_points == other.right_edge_points);
   }
 
   /**
@@ -115,10 +118,10 @@ struct GeometryStoreItem
     return !operator==(other);
   }
 
-  uint32_t leftEdgeOffset{0};
-  uint32_t rightEdgeOffset{0};
-  uint32_t leftEdgePoints{0};
-  uint32_t rightEdgePoints{0};
+  uint32_t left_edge_offset{0};
+  uint32_t right_edge_offset{0};
+  uint32_t left_edge_points{0};
+  uint32_t right_edge_points{0};
 };
 
 } // namespace access
@@ -157,17 +160,17 @@ namespace access {
 inline std::ostream &operator<<(std::ostream &os, GeometryStoreItem const &_value)
 {
   os << "GeometryStoreItem(";
-  os << "leftEdgeOffset:";
-  os << _value.leftEdgeOffset;
+  os << "left_edge_offset:";
+  os << _value.left_edge_offset;
   os << ",";
-  os << "rightEdgeOffset:";
-  os << _value.rightEdgeOffset;
+  os << "right_edge_offset:";
+  os << _value.right_edge_offset;
   os << ",";
-  os << "leftEdgePoints:";
-  os << _value.leftEdgePoints;
+  os << "left_edge_points:";
+  os << _value.left_edge_points;
   os << ",";
-  os << "rightEdgePoints:";
-  os << _value.rightEdgePoints;
+  os << "right_edge_points:";
+  os << _value.right_edge_points;
   os << ")";
   return os;
 }
@@ -187,4 +190,16 @@ inline std::string to_string(::ad::map::access::GeometryStoreItem const &value)
   return sstream.str();
 }
 } // namespace std
+
+/*!
+ * \brief overload of fmt::formatter calling std::to_string
+ */
+template <> struct fmt::formatter<::ad::map::access::GeometryStoreItem> : formatter<string_view>
+{
+  template <typename FormatContext> auto format(::ad::map::access::GeometryStoreItem const &value, FormatContext &ctx)
+  {
+    return formatter<string_view>::format(std::to_string(value), ctx);
+  }
+};
+
 #endif // GEN_GUARD_AD_MAP_ACCESS_GEOMETRYSTOREITEM

ad_map_access/generated/include/ad/map/access/GeometryStoreItem.hpp

@@ -1,7 +1,7 @@
 /*
  * ----------------- BEGIN LICENSE BLOCK ---------------------------------
  *
- * Copyright (C) 2018-2020 Intel Corporation
+ * Copyright (C) 2018-2022 Intel Corporation
  *
  * SPDX-License-Identifier: MIT
  *
@@ -12,7 +12,7 @@
  * Generated file
  * @file
  *
- * Generator Version : 11.0.0-1997
+ * Generator Version : 11.0.0-2046
  */
 
 #pragma once
@@ -100,7 +100,7 @@ struct MapMetaData
    */
   bool operator==(const MapMetaData &other) const
   {
-    return (trafficType == other.trafficType);
+    return (traffic_type == other.traffic_type);
   }
 
   /**
@@ -115,7 +115,7 @@ struct MapMetaData
     return !operator==(other);
   }
 
-  ::ad::map::access::TrafficType trafficType;
+  ::ad::map::access::TrafficType traffic_type;
 };
 
 } // namespace access
@@ -154,8 +154,8 @@ namespace access {
 inline std::ostream &operator<<(std::ostream &os, MapMetaData const &_value)
 {
   os << "MapMetaData(";
-  os << "trafficType:";
-  os << _value.trafficType;
+  os << "traffic_type:";
+  os << _value.traffic_type;
   os << ")";
   return os;
 }
@@ -175,4 +175,16 @@ inline std::string to_string(::ad::map::access::MapMetaData const &value)
   return sstream.str();
 }
 } // namespace std
+
+/*!
+ * \brief overload of fmt::formatter calling std::to_string
+ */
+template <> struct fmt::formatter<::ad::map::access::MapMetaData> : formatter<string_view>
+{
+  template <typename FormatContext> auto format(::ad::map::access::MapMetaData const &value, FormatContext &ctx)
+  {
+    return formatter<string_view>::format(std::to_string(value), ctx);
+  }
+};
+
 #endif // GEN_GUARD_AD_MAP_ACCESS_MAPMETADATA

ad_map_access/generated/include/ad/map/access/MapMetaData.hpp

@@ -1,7 +1,7 @@
 /*
  * ----------------- BEGIN LICENSE BLOCK ---------------------------------
  *
- * Copyright (C) 2018-2020 Intel Corporation
+ * Copyright (C) 2018-2022 Intel Corporation
  *
  * SPDX-License-Identifier: MIT
  *
@@ -12,7 +12,7 @@
  * Generated file
  * @file
  *
- * Generator Version : 11.0.0-1997
+ * Generator Version : 11.0.0-2046
  */
 
 #pragma once
@@ -38,7 +38,7 @@ inline bool withinValidInputRange(::ad::map::access::MapMetaData const &input, b
 {
   // check for generic member input ranges
   bool inValidInputRange = true;
-  inValidInputRange = withinValidInputRange(input.trafficType, logErrors);
+  inValidInputRange = withinValidInputRange(input.traffic_type, logErrors);
   if (!inValidInputRange && logErrors)
   {
     spdlog::error("withinValidInputRange(::ad::map::access::MapMetaData)>> {} has invalid member",