fix: assistant input overlap, mobile enter key, and tool result crashes

- Increase chat content spacer so the fixed input no longer overlaps the clear chat button
- Only submit on Enter with physical keyboards; mobile users tap the send button
- Guard all tool result components against undefined result.current
- Fix collapsed return/setState bug in person-update-result

Author: carlassmann

src/app/features/assistant/parts/chat-input.tsx

@@ -71,7 +71,10 @@ function ChatInput(props: {
 
 	function submitOnEnter(event: React.KeyboardEvent<HTMLTextAreaElement>) {
 		if (event.key !== "Enter") return
-		if (event.shiftKey) return
+		let hasPhysicalKeyboard = window.matchMedia(
+			"(hover: hover) and (pointer: fine)",
+		).matches
+		if (event.shiftKey || !hasPhysicalKeyboard) return
 
 		event.preventDefault()
 

src/app/features/assistant/parts/empty-chat-state.tsx

@@ -79,7 +79,10 @@ function EmptyChatState({
 
 	function submitOnEnter(event: React.KeyboardEvent<HTMLTextAreaElement>) {
 		if (event.key !== "Enter") return
-		if (event.shiftKey) return
+		let hasPhysicalKeyboard = window.matchMedia(
+			"(hover: hover) and (pointer: fine)",
+		).matches
+		if (event.shiftKey || !hasPhysicalKeyboard) return
 
 		event.preventDefault()
 

src/app/features/assistant/parts/note-create-result.tsx

@@ -39,6 +39,8 @@ function NoteCreateResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
 		if (!me.$isLoaded) return
 		setIsUndoing(true)

src/app/features/assistant/parts/note-delete-result.tsx

@@ -37,6 +37,8 @@ function NoteDeleteResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
 		if (!me.$isLoaded) return
 		setIsUndoing(true)

src/app/features/assistant/parts/note-update-result.tsx

@@ -38,6 +38,8 @@ function NoteUpdateResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
 		if (!me.$isLoaded) return
 		setIsUndoing(true)

src/app/features/assistant/parts/person-create-result.tsx

@@ -53,6 +53,8 @@ function PersonCreateResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
 		if (!me.$isLoaded) return
 		setIsUndoing(true)

src/app/features/assistant/parts/person-delete-result.tsx

@@ -46,6 +46,8 @@ function PersonDeleteResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
 		if (!me.$isLoaded) return
 		setIsUndoing(true)

src/app/features/assistant/parts/person-update-result.tsx

@@ -47,8 +47,11 @@ function PersonUpdateResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
-		if (!me.$isLoaded) return setIsUndoing(true)
+		if (!me.$isLoaded) return
+		setIsUndoing(true)
 		setDrawerOpen(false)
 		try {
 			await updatePerson(

src/app/features/assistant/parts/reminder-create-result.tsx

@@ -49,6 +49,8 @@ function ReminderCreateResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
 		if (!me.$isLoaded) return
 		setIsUndoing(true)

src/app/features/assistant/parts/reminder-delete-result.tsx

@@ -55,6 +55,8 @@ function ReminderDeleteResult({
 		)
 	}
 
+	if (!("current" in result) || !result.current) return null
+
 	let handleUndo = async () => {
 		if (!me.$isLoaded) return
 		setIsUndoing(true)