app: project: Add -i,--inactive flag to west list

In order for users to see which projects are currently inactive, add a
new -i/--inactive flag to list only inactive projects. Just like with
--all, giving an explicit list of projects overrides the flag.

Signed-off-by: Carles Cufi <[email protected]>

Author: carlescufi

src/west/app/project.py

@@ -428,6 +428,8 @@ def do_add_parser(self, parser_adder):
             epilog=f'''\
 {ACTIVE_PROJECTS_HELP}
 
+Note: To list only inactive projects you can use --inactive.
+
 FORMAT STRINGS
 --------------
 
@@ -453,11 +455,15 @@ def do_add_parser(self, parser_adder):
   that the project has been cloned.
 - cloned: "cloned" if the project has been cloned, "not-cloned"
   otherwise
+- active: "active" if the project is currently active, "inactive" otherwise
 - clone_depth: project clone depth if specified, "None" otherwise
 - groups: project groups, as a comma-separated list
 ''')
-        parser.add_argument('-a', '--all', action='store_true',
-                            help='include inactive projects'),
+        group = parser.add_mutually_exclusive_group(required=False)
+        group.add_argument('-a', '--all', action='store_true',
+                           help='include inactive projects'),
+        group.add_argument('-i', '--inactive', action='store_true',
+                           help='list only inactive projects'),
         parser.add_argument('--manifest-path-from-yaml', action='store_true',
                             help='''print the manifest repository's path
                             according to the manifest file YAML, which may
@@ -491,15 +497,27 @@ def cloned_thunk(project):
 
             return "cloned" if project.is_cloned() else "not-cloned"
 
+        def active_thunk(project):
+            self.die_if_no_git()
+
+            return "active" if self.manifest.is_active(project) else "inactive"
+
         def delay(func, project):
             return DelayFormat(partial(func, project))
 
+        if args.inactive and args.projects:
+            self.parser.error('-i cannot be combined with an explicit project '
+                              'list')
+
         for project in self._projects(args.projects):
-            # Skip inactive projects unless the user said
+            # Include the project based on the inactive flag. If the flag is
+            # set, include only inactive projects. Otherwise, include only
+            # active ones.
+            include = self.manifest.is_active(project) != bool(args.inactive)
+            # Skip active or inactive projects unless the user said
             # --all or named some projects explicitly.
-            if not (args.all or args.projects or
-                    self.manifest.is_active(project)):
-                self.dbg(f'{project.name}: skipping inactive project')
+            if not (args.all or args.projects or include):
+                self.dbg(f'{project.name}: skipping project')
                 continue
 
             # Spelling out the format keys explicitly here gives us
@@ -538,6 +556,7 @@ def delay(func, project):
                     revision=project.revision or 'N/A',
                     clone_depth=project.clone_depth or "None",
                     cloned=delay(cloned_thunk, project),
+                    active=delay(active_thunk, project),
                     sha=delay(sha_thunk, project),
                     groups=','.join(project.groups))
             except KeyError as e:

tests/test_project.py

@@ -225,11 +225,22 @@ def check(command_string, expected):
            'bar .. path-for-bar',
            'baz .baz-group. baz'])
 
+    check(_list_f('{name} .{groups}. {path} {active}') + ['--inactive'],
+          ['foo .foo-group-1,foo-group-2. foo inactive',
+           'baz .baz-group. baz inactive'])
+
+    check(_list_f("{name} .{groups}. {path} {active}") + ['--all'] + 'foo bar'.split(),
+          ['foo .foo-group-1,foo-group-2. foo inactive',
+           'bar .. path-for-bar active'])
+
+    with pytest.raises(subprocess.CalledProcessError):
+        cmd(_list_f("{name} .{groups}. {path}") + ['--inactive'] + 'foo bar'.split())
+
     cmd('config manifest.group-filter +foo-group-1')
-    check(_list_f('{name} .{groups}. {path}'),
-          ['manifest .. zephyr',
-           'foo .foo-group-1,foo-group-2. foo',
-           'bar .. path-for-bar'])
+    check(_list_f('{name} .{groups}. {path} {active}'),
+          ['manifest .. zephyr active',
+           'foo .foo-group-1,foo-group-2. foo active',
+           'bar .. path-for-bar active'])
 
 
 def test_list_sha(west_update_tmpdir):