fix:

add some fixes on the DurationTracer, like undefined variables or method passed params

add a basic test for DurationTracer

fix the tmp file name

Author: carlosdanielpohlod

lib/rails_tracepoint_stack/duration/output.rb

@@ -17,7 +17,7 @@ def show_top_files
       private
 
       def compute_duration!
-        File.open("log-boot-4.txt", "r").each_line do |line|
+        File.open("time_log.json", "r").each_line do |line|
           data = JSON.parse(line)
 
           file = data["file"]

lib/rails_tracepoint_stack/duration/tmp_save.rb

@@ -1,7 +1,8 @@
+require 'json'
 
 module RailsTracepointStack
-  module TmpSave
-    def self.save(trace:, last_time:)
+  class TmpSave
+    def self.save(trace:, current_time:, last_time:)
       duration = current_time - last_time
       log_obj = {
         time: current_time,
@@ -11,6 +12,7 @@ def self.save(trace:, last_time:)
         line: trace.line_number,
         duration: duration
       }
+      p log_obj
       File.open("time_log.json", "a") do |file|
         file.puts log_obj.to_json
       end

lib/rails_tracepoint_stack/duration_tracer.rb

@@ -3,22 +3,22 @@
 
 module RailsTracepointStack
   class DurationTracer < RailsTracepointStack::TracerBase
-    
+
     private
 
     def generate_tracer
-     TracePoint.new(:line) do |tracepoint|
+      @tracer ||= TracePoint.new(:line) do |tracepoint|
         trace = RailsTracepointStack::Trace.new(trace_point: tracepoint)
-
+       
         next if ignore_trace?(trace: trace)
 
         current_time = Process.clock_gettime(Process::CLOCK_MONOTONIC)
-
-        if last_time
-          RailsTracepointStack::TmpSave.save(trace: trace, last_time: last_time)
+        
+        if defined?(@last_time)
+          RailsTracepointStack::TmpSave.save(trace: trace, current_time: current_time, last_time: @last_time)
         end
 
-        last_time = current_time
+        @last_time = current_time
       end
     end
   end

spec/rails_tracepoint_stack/duration_tracer_spec.rb

@@ -0,0 +1,69 @@
+require "spec_helper"
+require_relative "../../lib/rails_tracepoint_stack/duration_tracer"
+
+class Foo
+  def dummy_method
+    nil
+  end
+
+  def dummy_method_with_params(param_1, param_2)
+    nil
+  end
+end
+
+RSpec.describe RailsTracepointStack::DurationTracer do
+  let(:tracer) { RailsTracepointStack::DurationTracer.new }
+
+  before do
+    allow(RailsTracepointStack::TmpSave)
+      .to receive(:save)
+      .and_return(true)
+
+    allow_any_instance_of(TracePoint)
+      .to receive(:lineno).and_return(6)
+
+    allow_any_instance_of(TracePoint)
+      .to receive(:defined_class).and_return(Foo)
+
+    allow_any_instance_of(TracePoint)
+      .to receive(:method_id).and_return(:dummy_method)
+
+    allow_any_instance_of(TracePoint)
+      .to receive(:path).and_return("/stubbed/path/to/file.rb")
+  end
+
+  describe "when the log should not be ignored because not match any filter block" do
+    before do
+      allow(RailsTracepointStack::Filter::GemPath)
+        .to receive(:full_gem_path)
+        .and_return(["/another/path/to/gem"])
+
+      allow(RailsTracepointStack::Filter::RbConfig)
+        .to receive(:ruby_lib_path)
+        .and_return("/path/to/ruby/lib")
+
+      allow_any_instance_of(TracePoint)
+        .to receive(:path)
+        .and_return("/app/rails_tracepoint_stack/spec/tracer_spec.rb")
+
+      allow_any_instance_of(RailsTracepointStack::Configuration)
+        .to receive(:log_format)
+        .and_return(:text)
+    end
+
+    it "calls logger with correct params" do
+      tracer.enable do
+        Foo.new.dummy_method
+        Foo.new.dummy_method
+      end
+
+      expect(RailsTracepointStack::TmpSave)
+        .to have_received(:save)
+        .with(
+          trace: an_instance_of(RailsTracepointStack::Trace),
+          current_time: an_instance_of(Float),
+          last_time: an_instance_of(Float)
+        )
+    end
+  end
+end