Merge pull request #33 from PauloVilarinho/refactor-tracer-class

refactor tracer class

Author: carlosdanielpohlod

lib/rails_tracepoint_stack.rb

@@ -20,7 +20,7 @@ def self.configure
   def self.enable_trace
     raise ArgumentError, "Block not given to #enable_trace" unless block_given?
 
-    tracer = RailsTracepointStack::Tracer.new.tracer
+    tracer = RailsTracepointStack::Tracer.new
     tracer.enable
     yield
   ensure
@@ -29,7 +29,7 @@ def self.enable_trace
 end
 
 if ENV.fetch("RAILS_TRACEPOINT_STACK_ENABLED", "false") == "true"
-  $rails_tracer_rtps = RailsTracepointStack::Tracer.new.tracer
+  $rails_tracer_rtps = RailsTracepointStack::Tracer.new
   $rails_tracer_rtps.enable
 
   at_exit do

lib/rails_tracepoint_stack/tracer.rb

@@ -7,8 +7,17 @@
 module RailsTracepointStack
   class Tracer
     include RailsTracepointStack::TraceFilter
-    # TODO: Tracer.new shoud return the tracer. Is weird to call Tracer.new.tracer
-    def tracer
+    extend Forwardable
+ 
+    def_delegators :@tracer, :enable, :disable
+
+    def initialize
+      generate_tracer
+    end
+
+    private
+
+    def generate_tracer
       @tracer ||= TracePoint.new(:call) do |tracepoint|
         trace = RailsTracepointStack::Trace.new(trace_point: tracepoint)
 

spec/rails_tracepoint_stack/tracer_spec.rb

@@ -63,7 +63,7 @@ def dummy_method_with_params(param_1, param_2)
     end
 
     it "does not call logger" do
-      tracer.tracer.enable do
+      tracer.enable do
         Foo.new.dummy_method
       end
 
@@ -91,7 +91,7 @@ def dummy_method_with_params(param_1, param_2)
     end
 
     it 'does not call logger' do
-      tracer.tracer.enable do
+      tracer.enable do
         Foo.new.dummy_method
       end
 
@@ -119,7 +119,7 @@ def dummy_method_with_params(param_1, param_2)
     end
 
     it 'calls logger' do
-      tracer.tracer.enable do
+      tracer.enable do
         Foo.new.dummy_method
       end
 
@@ -147,7 +147,7 @@ def dummy_method_with_params(param_1, param_2)
     end
 
     it 'does not call logger' do
-      tracer.tracer.enable do
+      tracer.enable do
         Foo.new.dummy_method
       end
 
@@ -179,7 +179,7 @@ def dummy_method_with_params(param_1, param_2)
     end
 
     it "calls logger" do
-      tracer.tracer.enable do
+      tracer.enable do
         Foo.new.dummy_method
       end
 

spec/shared/tracer_examples.rb

@@ -1,7 +1,7 @@
 RSpec.shared_examples "tracer success examples asserts" do
   context "when log format is text" do
     it 'calls logger with correct log' do
-      tracer.tracer.enable do
+      tracer.enable do
         Foo.new.dummy_method
       end
 
@@ -19,7 +19,7 @@
     end
     # TODO: Extract this test to a proper place
     it 'calls logger with correct log with json log format' do
-      tracer.tracer.enable do
+      tracer.enable do
         Foo.new.dummy_method
       end