Skip to content

Commit 8cb0a68

Browse files
remove metrics
Signed-off-by: Carlos Feria <2582866+carlosthe19916@users.noreply.github.com>
1 parent 166c1d2 commit 8cb0a68

3 files changed

Lines changed: 26 additions & 97 deletions

File tree

client/src/app/pages/sbom-scan/sbom-scan.tsx

Lines changed: 17 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@ import {
2121
PageSection,
2222
Split,
2323
SplitItem,
24-
Stack,
25-
StackItem,
2624
type MenuToggleElement,
2725
} from "@patternfly/react-core";
2826

@@ -35,7 +33,6 @@ import { useUploadAndAnalyzeSBOM } from "@app/queries/sboms-analysis";
3533
import { Paths } from "@app/Routes";
3634

3735
import { useVulnerabilitiesOfSbomByPurls } from "@static-report/hooks/useVulnerabilitiesOfSbom";
38-
import { VulnerabilityMetrics } from "@static-report/pages/vulnerabilities/components/VulnerabilitiesMetrics";
3936
import { VulnerabilityTable } from "@static-report/pages/vulnerabilities/components/VulnerabilityTable";
4037

4138
import { UploadFileForAnalysis } from "./components/UploadFileForAnalysis";
@@ -67,7 +64,7 @@ export const SbomScan: React.FC = () => {
6764
}, [uploadResponseData]);
6865

6966
const {
70-
data: { vulnerabilities, summary },
67+
data: { vulnerabilities },
7168
analysisResponse,
7269
isFetching,
7370
fetchError,
@@ -98,20 +95,27 @@ export const SbomScan: React.FC = () => {
9895
});
9996
};
10097

98+
const reportNotReady =
99+
uploadResponseData === null || isFetching || fetchError;
100+
101101
return (
102102
<>
103103
<PageSection type="breadcrumb">
104104
<Breadcrumb>
105105
<BreadcrumbItem>
106106
<Link to={Paths.sboms}>SBOMs</Link>
107107
</BreadcrumbItem>
108-
<BreadcrumbItem isActive>
109-
Generate vulnerability report
110-
</BreadcrumbItem>
108+
{reportNotReady ? (
109+
<BreadcrumbItem isActive>
110+
Generate vulnerability report
111+
</BreadcrumbItem>
112+
) : (
113+
<BreadcrumbItem isActive>Vulnerability report</BreadcrumbItem>
114+
)}
111115
</Breadcrumb>
112116
</PageSection>
113117
<PageSection>
114-
{uploadResponseData === null || isFetching || fetchError ? (
118+
{reportNotReady ? (
115119
<Content>
116120
<Content component="h1">Generate vulnerability report</Content>
117121
<Content component="p">
@@ -209,22 +213,11 @@ export const SbomScan: React.FC = () => {
209213
</EmptyStateFooter>
210214
</EmptyState>
211215
) : (
212-
<Stack hasGutter>
213-
<StackItem>
214-
<VulnerabilityMetrics
215-
summary={summary}
216-
isFetching={isFetching}
217-
fetchError={fetchError}
218-
/>
219-
</StackItem>
220-
<StackItem>
221-
<VulnerabilityTable
222-
vulnerabilities={vulnerabilities}
223-
isFetching={isFetching}
224-
fetchError={fetchError}
225-
/>
226-
</StackItem>
227-
</Stack>
216+
<VulnerabilityTable
217+
vulnerabilities={vulnerabilities}
218+
isFetching={isFetching}
219+
fetchError={fetchError}
220+
/>
228221
)}
229222
</PageSection>
230223
</>

client/src/static-report/pages/vulnerabilities/components/VulnerabilitiesMetrics.tsx

Lines changed: 0 additions & 64 deletions
This file was deleted.

client/src/static-report/pages/vulnerabilities/components/VulnerabilityTable.tsx

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ export const VulnerabilityTable: React.FC<IVulnerabilityTableProps> = ({
7171
columnNames: {
7272
vulnerabilityId: "Vulnerability ID",
7373
description: "Description",
74-
status: "Status",
7574
severity: "Severity",
75+
status: "Status",
7676
affectedPackages: "Affected packages",
7777
published: "Published",
7878
updated: "Updated",
@@ -185,8 +185,8 @@ export const VulnerabilityTable: React.FC<IVulnerabilityTableProps> = ({
185185
<TableHeaderContentWithControls {...tableControls}>
186186
<Th {...getThProps({ columnKey: "vulnerabilityId" })} />
187187
<Th {...getThProps({ columnKey: "description" })} />
188-
<Th {...getThProps({ columnKey: "status" })} />
189188
<Th {...getThProps({ columnKey: "severity" })} />
189+
<Th {...getThProps({ columnKey: "status" })} />
190190
<Th {...getThProps({ columnKey: "affectedPackages" })} />
191191
<Th {...getThProps({ columnKey: "published" })} />
192192
<Th {...getThProps({ columnKey: "updated" })} />
@@ -245,13 +245,6 @@ export const VulnerabilityTable: React.FC<IVulnerabilityTableProps> = ({
245245
</Td>
246246
)}
247247
</TdWithFocusStatus>
248-
<Td
249-
width={10}
250-
modifier="truncate"
251-
{...getTdProps({ columnKey: "status" })}
252-
>
253-
{item.status}
254-
</Td>
255248
<Td
256249
width={10}
257250
modifier="breakWord"
@@ -277,6 +270,13 @@ export const VulnerabilityTable: React.FC<IVulnerabilityTableProps> = ({
277270
/>
278271
</Popover>
279272
</Td>
273+
<Td
274+
width={10}
275+
modifier="truncate"
276+
{...getTdProps({ columnKey: "status" })}
277+
>
278+
{item.status}
279+
</Td>
280280
<Td
281281
width={10}
282282
modifier="truncate"

0 commit comments

Comments
 (0)