bug: Old uploads stay in storage after update

[avgerin0s]

When updating a document's attachment, the old attachment does not get deleted.

An example application that demonstrates this bug can be found here.

The related test looks like this

test "it deletes old images upon update" do
    doc = Zedocument.new

    # Initial image and creation
    doc.remote_filename_url = "https://www.ruby-lang.org/images/header-ruby-logo.png"
    doc.save

    old_path = doc.filename.path

    assert(File.exists?(old_path))

    # Update the image
    doc.remote_filename_url = "http://memesvault.com/wp-content/uploads/Wat-Meme-Old-Lady-01.jpg"
    doc.save

    new_path = doc.filename.path

    assert_not_equal(new_path, old_path)

    assert(File.exists?(new_path))
    assert_not(File.exists?(old_path))
  end

An example workaround I used for a forked version is this for carrierwave-mongoid as well as this for carrierwave because mongoid returns a Hash as with Strings keys for changes.

If you agree with those changes I can craft a PR for carrierwave-mongoid and I can merge the carrierwave changes.

[avgerin0s]

The same problem continues to exist for carrierwave v0.11

[rmm5t]

Yes, a PR would be much appreciated. Thanks.

[rmm5t]

Related to #125?

[leoarnold]

I translated @avgerin0s's initial example to RSpec, but was not able to reproduce.

The following spec passes with all versions of Ruby, Mongoid and CarrierWave:

  describe "Issue 159" do
    let(:model_class) { reset_mongo_class }

    it 'deletes the old path' do
      doc = model_class.new

      # Initial image and creation
      doc.remote_image_url = 'https://picsum.photos/500'
      doc.save

      old_path = doc.image.path

      expect(File).to exist(old_path)

      # Update the image
      doc.remote_image_url = 'https://picsum.photos/200'
      doc.save

      new_path = doc.image.path

      expect(new_path).to_not eq(old_path)

      expect(File).to exist(new_path)
      expect(File).to_not exist(old_path)
    end
  end