Code cleanup

carsonip · carsonip · commit 93fcaf37029d · 2017-10-02T13:55:58.000+08:00
diff --git a/src/parser.cpp b/src/parser.cpp
@@ -20,10 +20,8 @@ std::vector<Engine::SubtitleItem> Parser::parseFile(QFile &f,
         for (QString ext : p->getExtensions()) {
             ok = ok || f.fileName().endsWith(ext, Qt::CaseInsensitive);
         }
-        if (!ok)
-            continue;
-
-        return p->parseFile(f, encoding);
+        if (ok)
+            return p->parseFile(f, encoding);
     }
     return std::vector<Engine::SubtitleItem>();
 }

Original file line number	Diff line number	Diff line change
`@@ -20,10 +20,8 @@ std::vector<Engine::SubtitleItem> Parser::parseFile(QFile &f,`
`20`	`20`	`for (QString ext : p->getExtensions()) {`
`21`	`21`	`ok = ok \|\| f.fileName().endsWith(ext, Qt::CaseInsensitive);`
`22`	`22`	`}`
`23`		`- if (!ok)`
`24`		`- continue;`
`25`		`-`
`26`		`- return p->parseFile(f, encoding);`
	`23`	`+ if (ok)`
	`24`	`+ return p->parseFile(f, encoding);`
`27`	`25`	`}`
`28`	`26`	`return std::vector<Engine::SubtitleItem>();`
`29`	`27`	`}`