perf(analyzer): remove intermediate Vec allocation when extending

Signed-off-by: azjezz <[email protected]>

Author: azjezz

crates/analyzer/src/expression/mod.rs

@@ -333,7 +333,7 @@ pub fn find_expression_logic_issues<'ctx, 'arena>(
     // this will see whether any of the clauses in set A conflict with the clauses in set B
     check_for_paradox(&mut context.collector, &block_context.clauses, &expression_clauses, expression_span);
 
-    expression_clauses.extend(block_context.clauses.iter().map(|v| (**v).clone()).collect::<Vec<_>>());
+    expression_clauses.extend(block_context.clauses.iter().map(|v| (**v).clone()));
 
     let (reconcilable_if_types, active_if_types) = find_satisfying_assignments(
         expression_clauses.iter().as_slice(),

crates/analyzer/src/statement/switch.rs

@@ -417,7 +417,7 @@ impl<'anlyz, 'ctx, 'arena> SwitchAnalyzer<'anlyz, 'ctx, 'arena> {
                     self.context.arena,
                     switch_condition,
                     case_condition,
-                    previous_empty_cases.clone().into_iter().map(|c| c.expression).collect::<Vec<_>>(),
+                    previous_empty_cases.iter().map(|c| c.expression).collect::<Vec<_>>(),
                 )
             } else if switch_condition_type.is_true() {
                 case_condition.clone()