fix(analyzer): don't flag concrete-to-template type assertions as redundant

Signed-off-by: azjezz <[email protected]>

Author: azjezz

crates/analyzer/src/invocation/post_process.rs

@@ -412,6 +412,7 @@ fn resolve_invocation_assertion<'ctx, 'ast, 'arena>(
                         if always_redundant
                             && let Some(asserted_type) = &asserted_type
                             && !asserted_type.is_mixed()
+                            && !resolved_assertion_type.has_template()
                         {
                             let mut comparison_result = ComparisonResult::default();
                             let is_subtype = is_contained_by(

crates/analyzer/tests/cases/assert_concrete_to_template_type.php

@@ -0,0 +1,25 @@
+<?php
+
+/**
+ * @template T of array-key
+ */
+interface TypeInterface
+{
+    /**
+     * @return T
+     */
+    public function assert(mixed $value): mixed;
+}
+
+/**
+ * @template T of array-key
+ *
+ * @param TypeInterface<T> $type
+ * @param array-key $value
+ *
+ * @return T
+ */
+function narrow_to_t(TypeInterface $type, mixed $value): mixed
+{
+    return $type->assert($value);
+}

crates/analyzer/tests/mod.rs

@@ -35,6 +35,7 @@ test_case!(accessing_undefined_class_constant);
 test_case!(argument_count);
 test_case!(array_list_reconciliation);
 test_case!(array_shape_fields);
+test_case!(assert_concrete_to_template_type);
 test_case!(assert_generic_array_key_is_array_key);
 test_case!(bare_identifier_in_array_access);
 test_case!(by_reference_invalidation);