fix(formatter): default null-type-hint to question mark syntax for PER-CS compliance

closes #771

Signed-off-by: azjezz <[email protected]>

Author: azjezz

crates/formatter/src/settings.rs

@@ -555,21 +555,21 @@ pub struct FormatSettings {
 
     /// How to format null type hints.
     ///
-    /// With `NullPipe`:
+    /// With `Question`:
     /// ```php
-    /// function foo(null|string $bar) {
+    /// function foo(?string $bar) {
     ///     return $bar;
     /// }
     /// ```
     ///
-    /// With `Question`:
+    /// With `NullPipe`:
     /// ```php
-    /// function foo(?string $bar) {
+    /// function foo(null|string $bar) {
     ///     return $bar;
     /// }
     /// ```
     ///
-    /// Default: `NullPipe`
+    /// Default: `Question`
     #[serde(default)]
     pub null_type_hint: NullTypeHint,
 
@@ -1083,9 +1083,9 @@ impl FromStr for EndOfLine {
 /// Specifies null type hint style.
 #[derive(Default, Debug, Clone, Copy, Eq, PartialEq, Hash, Serialize, Deserialize, PartialOrd, Ord, JsonSchema)]
 pub enum NullTypeHint {
-    #[default]
     #[serde(alias = "null_pipe", alias = "pipe", alias = "long", alias = "|")]
     NullPipe,
+    #[default]
     #[serde(alias = "question", alias = "short", alias = "?")]
     Question,
 }

crates/formatter/tests/cases/attributes/settings.inc

@@ -1,3 +1,4 @@
 FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
     ..Default::default()
 }

crates/formatter/tests/cases/awaitable/settings.inc

@@ -1 +1,4 @@
-FormatSettings::default()
+FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
+    ..Default::default()
+}

crates/formatter/tests/cases/issue_166/settings.inc

@@ -1,4 +1,5 @@
 FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
     preserve_breaking_parameter_list: true,
     break_promoted_properties_list: false,
     ..Default::default()

crates/formatter/tests/cases/issue_197/settings.inc

@@ -1,4 +1,5 @@
 FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
     always_break_named_arguments_list: true,
     ..Default::default()
 }

crates/formatter/tests/cases/issue_208/settings.inc

@@ -1,4 +1,5 @@
 FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
     empty_line_before_return: true,
     ..Default::default()
 }

crates/formatter/tests/cases/pipe_operator/settings.inc

@@ -1 +1,4 @@
-FormatSettings::default()
+FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
+    ..Default::default()
+}

crates/formatter/tests/cases/spacing_options/settings.inc

@@ -1,4 +1,5 @@
 FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
     always_break_named_arguments_list: true,
     ..Default::default()
 }

crates/formatter/tests/cases/spacing_options_flipped/settings.inc

@@ -1,4 +1,5 @@
 FormatSettings {
+    null_type_hint: NullTypeHint::NullPipe,
     always_break_named_arguments_list: true,
     space_around_assignment_in_declare: true,
     space_within_grouping_parenthesis: true,

crates/formatter/tests/mod.rs

@@ -4,6 +4,7 @@ use std::fs;
 
 use mago_formatter::Formatter;
 use mago_formatter::settings::FormatSettings;
+use mago_formatter::settings::NullTypeHint;
 use mago_php_version::PHPVersion;
 
 #[macro_export]