fix(codex): expand properties-of<T> to array<non-empty-string, mixed> for generic object constraints

closes #759

Signed-off-by: azjezz <[email protected]>

Author: azjezz

crates/analyzer/tests/cases/properties_of_generic.php

@@ -0,0 +1,20 @@
+<?php
+
+declare(strict_types=1);
+
+abstract class AbstractProperty
+{
+    /**
+     * @template T of object
+     *
+     * @param T $object
+     * @param key-of<properties-of<T>> $field
+     */
+    public static function isInitialized(object $object, string $field): bool
+    {
+        // @mago-expect analysis:unhandled-thrown-type
+        $property = new ReflectionProperty($object::class, $field);
+
+        return $property->isInitialized($object);
+    }
+}

crates/analyzer/tests/mod.rs

@@ -153,6 +153,7 @@ test_case!(readonly_proptected_set);
 test_case!(value_of_enum_resolution);
 test_case!(properties_of_enum);
 test_case!(properties_of_class);
+test_case!(properties_of_generic);
 test_case!(properties_of_visibility);
 test_case!(assert_or_type);
 test_case!(impossible_assertion);

crates/codex/src/ttype/atomic/derived/properties_of.rs

@@ -18,7 +18,7 @@ use crate::ttype::atomic::object::TObject;
 use crate::ttype::atomic::object::r#enum::TEnum;
 use crate::ttype::atomic::scalar::TScalar;
 use crate::ttype::get_mixed;
-use crate::ttype::get_string;
+use crate::ttype::get_non_empty_string;
 use crate::ttype::union::TUnion;
 use crate::visibility::Visibility;
 
@@ -194,23 +194,27 @@ impl TPropertiesOf {
                         }
                     }
                 }
-                TAtomic::GenericParameter(_parameter) => {
-                    // For generic parameters, we can't expand at this point
-                    // The caller should handle unexpanded types
+                TAtomic::GenericParameter(parameter) => {
+                    if parameter.get_constraint().is_objecty() {
+                        needs_unsealed = true;
+                    }
                 }
                 _ => {}
             }
         }
 
-        if known_items.is_empty() {
+        if known_items.is_empty() && !needs_unsealed {
             None
         } else {
-            let mut keyed_array = TKeyedArray::new().with_known_items(known_items).with_non_empty(true);
+            let has_known_items = !known_items.is_empty();
+            let mut keyed_array = TKeyedArray::new().with_known_items(known_items);
 
-            // For non-final classes, make the array unsealed to indicate
-            // that subclasses may have additional properties
             if needs_unsealed {
-                keyed_array = keyed_array.with_parameters(Box::new(get_string()), Box::new(get_mixed()));
+                keyed_array = keyed_array.with_parameters(Box::new(get_non_empty_string()), Box::new(get_mixed()));
+            }
+
+            if has_known_items {
+                keyed_array = keyed_array.with_non_empty(true);
             }
 
             Some(TAtomic::Array(TArray::Keyed(keyed_array)))