fix(build, ci): fix windows stack overflow and drop 32-bit support

This commit introduces a robust, code-based fix for the build-time stack overflow on windows and simplifies our build matrix by dropping support for 32-bit targets.

Signed-off-by: azjezz <[email protected]>

Author: azjezz

.cargo/config.toml

@@ -67,26 +67,22 @@ jobs:
 
           # Tier 1 targets:
 
-          ## Windows MSVC: x86_64, i686
-          - { target: i686-pc-windows-msvc, os: windows-latest, test: true }
+          ## Windows MSVC: x86_64
           - { target: x86_64-pc-windows-msvc, os: windows-latest, test: true }
           ## macOS: aarch64, x86_64
           - { target: aarch64-apple-darwin, os: macos-latest, test: true }
           - { target: x86_64-apple-darwin, os: macos-latest, test: true }
-          ## Linux: aarch64, i686, x86_64
+          ## Linux: aarch64, x86_64
           - { target: aarch64-unknown-linux-gnu, os: ubuntu-latest, test: true, debian-package: true }
           - { target: aarch64-unknown-linux-musl, os: ubuntu-latest, test: true }
-          - { target: i686-unknown-linux-gnu, os: ubuntu-latest, test: true, debian-package: true }
-          - { target: i686-unknown-linux-musl, os: ubuntu-latest, test: true }
           - { target: x86_64-unknown-linux-gnu, os: ubuntu-latest, test: true, wasm: true, debian-package: true }
           - { target: x86_64-unknown-linux-musl, os: ubuntu-latest, test: true }
 
           # Tier 2 targets:
 
           # Windows MinGW: x86_64
           - { target: x86_64-pc-windows-gnu, os: windows-latest }
-          # FreeBSD: x86_64, i686
-          - { target: i686-unknown-freebsd, os: ubuntu-latest }
+          # FreeBSD: x86_64
           - { target: x86_64-unknown-freebsd, os: ubuntu-latest }
           # Linux: arm, armv7, powerpc, powerpc64, powerpc64le, s390x
           - { target: arm-unknown-linux-gnueabi, os: ubuntu-latest }
@@ -121,7 +117,6 @@ jobs:
           case ${{ matrix.job.target }} in
             arm-unknown-linux-*) sudo apt-get -y install gcc-arm-linux-gnueabihf ;;
             aarch64-unknown-linux-gnu) sudo apt-get -y install gcc-aarch64-linux-gnu ;;
-            i686-unknown-linux-gnu) sudo apt-get -y install gcc-multilib g++-multilib ;;
             arm-unknown-linux-gnueabihf) sudo apt-get -y install gcc-arm-linux-gnueabihf g++-arm-linux-gnueabihf qemu-user ;;
           esac
 
@@ -149,7 +144,6 @@ jobs:
           IMAGE=""
           case ${{ matrix.job.target }} in
             x86_64-unknown-linux-gnu) IMAGE="quay.io/pypa/manylinux2014_x86_64" ;;
-            i686-unknown-linux-gnu) IMAGE="quay.io/pypa/manylinux2014_i686" ;;
             aarch64-unknown-linux-gnu) IMAGE="quay.io/pypa/manylinux2014_aarch64" ;;
             powerpc64le-unknown-linux-gnu) IMAGE="quay.io/pypa/manylinux2014_ppc64le" ;;
             s390x-unknown-linux-gnu) IMAGE="quay.io/pypa/manylinux2014_s390x" ;;
@@ -173,7 +167,7 @@ jobs:
           cargo -V
           rustc -V
 
-      - name: build
+      - name: build 
         shell: bash
         run: $BUILD_CMD build --locked --release --target=${{ matrix.job.target }}
 
@@ -199,15 +193,8 @@ jobs:
           echo "binary for target '${{ matrix.job.target }}' requires the following GLIBC versions:"
           strings "${{ steps.bin.outputs.BIN_PATH }}" | grep GLIBC_ || echo "No GLIBC version strings found."
 
-      - name: run tests (Windows)
-        if: matrix.job.test && !startsWith(github.ref, 'refs/pull/') && contains(matrix.job.target, '-pc-windows-')
-        shell: bash
-        env:
-          RUSTFLAGS: "-C link-arg=/STACK:8388608"
-        run: $BUILD_CMD test --workspace --locked --target=${{ matrix.job.target }}
-
-      - name: run tests (non-Windows)
-        if: matrix.job.test && !startsWith(github.ref, 'refs/pull/') && !contains(matrix.job.target, '-pc-windows-')
+      - name: run tests
+        if: matrix.job.test && !startsWith(github.ref, 'refs/pull/')
         shell: bash
         run: $BUILD_CMD test --workspace --locked --target=${{ matrix.job.target }}
 
@@ -287,7 +274,6 @@ jobs:
           # Derive arch from target:
           case "$TARGET" in
             *x86_64*) DPKG_ARCH="amd64" ;;
-            *i686*) DPKG_ARCH="i686" ;;
             *aarch64*|*arm64*) DPKG_ARCH="arm64" ;;
             *arm*hf*) DPKG_ARCH="armhf" ;;
             *arm*) DPKG_ARCH="armel" ;;

.github/workflows/cd.yml

@@ -55,14 +55,14 @@ jobs:
 
       - name: cargo clippy
         if: matrix.os == 'macos-latest'
-        run: cargo clippy --workspace --all-targets --all-features -- -D warnings
+        run: cargo clippy --workspace --all-features -- -D warnings
 
       - name: cargo test
-        run: cargo test --workspace --locked --all-targets
+        run: cargo test --workspace --locked
 
       - name: cargo build
-        if: matrix.rust == 'stable' && matrix.os == 'ubuntu-latest'
-        run: cargo build --workspace --release --locked --all-targets
+        if: matrix.rust == 'stable'
+        run: cargo build --release --locked
 
       - name: Install PHP
         if: matrix.rust == 'stable' && matrix.os == 'ubuntu-latest'

.github/workflows/ci.yml

@@ -12,8 +12,16 @@ pub fn main() -> io::Result<()> {
     let out_dir = std::env::var("OUT_DIR").expect("OUT_DIR environment variable not set");
     let prelude_file = Path::new(&out_dir).join("prelude.bin");
 
-    let prelude = Prelude::build();
-    let prelude_bin = prelude.encode().expect("Failed to encode the prelude");
+    let prelude_bin = std::thread::Builder::new()
+        .stack_size(36 * 1024 * 1024)
+        .name("prelude_builder".into())
+        .spawn(|| {
+            let prelude = Prelude::build();
+
+            prelude.encode().expect("Failed to encode the prelude")
+        })?
+        .join()
+        .expect("Failed to join prelude thread");
 
     fs::write(prelude_file, prelude_bin)?;