chore(formatter): relax binary inlining rules

Signed-off-by: azjezz <[email protected]>

Author: azjezz

crates/formatter/src/internal/format/binaryish.rs

@@ -164,6 +164,12 @@ pub(super) fn print_binaryish_expression<'arena>(
     let parts = print_binaryish_expression_parts(f, left, operator, right, is_inside_parenthesis, false);
 
     if is_inside_parenthesis {
+        let lhs_is_binary = left.is_binary();
+        let rhs_is_binary = right.is_binary();
+        if !lhs_is_binary && !rhs_is_binary {
+            return Document::Group(Group::new(parts));
+        }
+
         return Document::Array(parts);
     }
 

crates/formatter/tests/cases/issue_279/after.php

@@ -2,8 +2,7 @@
 
 if (
     in_array($object->getVeryLongAndInterestingObjectType(), SuperClass::VERY_LONG_AND_DESCRIPTIVE_CONSTANT_NAME) && (
-        !$object->veryLongConditionCheckWithLotsOfText()
-        && !$object->evenLongerConditionCheckWithEvenMoreText()
+        !$object->veryLongConditionCheckWithLotsOfText() && !$object->evenLongerConditionCheckWithEvenMoreText()
     )
 ) {
 }
@@ -25,8 +24,7 @@
                 $object->getVeryLongAndInterestingObjectType(),
                 SuperClass::VERY_LONG_AND_DESCRIPTIVE_CONSTANT_NAME,
             ) && (
-                !$object->veryLongConditionCheckWithLotsOfText()
-                && !$object->evenLongerConditionCheckWithEvenMoreText()
+                !$object->veryLongConditionCheckWithLotsOfText() && !$object->evenLongerConditionCheckWithEvenMoreText()
             )
         ) {
         }

crates/formatter/tests/cases/issue_796/after.php

@@ -4,11 +4,9 @@
     $x &&
     // Condition A
     (
-        $x
-        && $x ||
+        $x && $x ||
         // Condition B
-        $x
-        && $x
+        $x && $x
     )
 ) {
 }