Inconsistent assertions style

[ruudk]

https://docs.phpunit.de/en/12.3/assertions.html#assertions

The docs say you should write $this-> assertNull. But since these are static methods, we should write self::assertNull.
The test is already extending from the TestCase which extends from \PHPUnit\Framework\Assert.

Why does Mago lint suggest me to write static::assertNull instead?

warning[assertion-style]: Inconsistent assertions style.
   ┌─ tests/Simple/SimpleTest.php:36:9
   │
36 │         self::assertNull($project->description);
   │         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ This assertion uses the `self::` style.
   │
   = Help: Use `static::` instead of `self::` to conform to the `static` style.

Why is static better than self in this case?

[azjezz]

This is a consistency rule, it makes sure your team is using one style all over.

https://mago.carthage.software/tools/linter/rules/consistency#assertion-style

The static:: is just the default one, but i think since PHPUnit suggests $this->, the it should be the default style.

You can configure it as follows:

[linter.rules]
assertion-style = { style = "self" } # or "this" or "static"

[ruudk]

ERROR Failed to build the configuration: unknown variant `self`, expected one of `static`, `self_`, `this` for key `linter.rules.assertion-style`

Needs to be self_ for some reason.

[azjezz]

the some reason is that rust does not allow using Self as a keyword :P i will add an alias for "self"