Fix formatted string error

Signed-off-by: Unnati Mishra <[email protected]>

Fix formatted string error

Signed-off-by: Unnati Mishra <[email protected]>

Author: CodesbyUnnati

cli/pkg/kctrl/cmd/app/app_tailer.go

@@ -194,7 +194,7 @@ func (d *AppStatusDiff) PrintUpdate() (bool, string, error) {
 				msg := "Fetch failed"
 				errLog := d.new.Fetch.Stderr + "\n" + d.new.Fetch.Error
 				d.statusUI.PrintLogLine(msg, errLog, true, d.new.Fetch.UpdatedAt.Time)
-				return true, d.lastSeenDeployStdout, fmt.Errorf(msg)
+				return true, d.lastSeenDeployStdout, fmt.Errorf("%s", msg)
 			}
 			d.statusUI.PrintLogLine("Fetching", d.new.Fetch.Stdout, false, d.new.Fetch.UpdatedAt.Time)
 			d.statusUI.PrintLogLine("Fetch succeeded", "", false, d.new.Fetch.UpdatedAt.Time)
@@ -206,7 +206,7 @@ func (d *AppStatusDiff) PrintUpdate() (bool, string, error) {
 				msg := "Template failed"
 				errLog := d.new.Template.Stderr + "\n" + d.new.Template.Error
 				d.statusUI.PrintLogLine(msg, errLog, true, d.new.Template.UpdatedAt.Time)
-				return true, d.lastSeenDeployStdout, fmt.Errorf(msg)
+				return true, d.lastSeenDeployStdout, fmt.Errorf("%s", msg)
 			}
 			d.statusUI.PrintLogLine("Template succeeded", "", false, d.new.Template.UpdatedAt.Time)
 		}
@@ -226,7 +226,7 @@ func (d *AppStatusDiff) PrintUpdate() (bool, string, error) {
 				msg := fmt.Sprintf("%s failed", ongoingOp)
 				errLog := d.new.Deploy.Stderr + "\n" + d.new.Deploy.Error
 				d.statusUI.PrintLogLine(msg, errLog, true, d.new.Deploy.UpdatedAt.Time)
-				return true, d.lastSeenDeployStdout, fmt.Errorf(msg)
+				return true, d.lastSeenDeployStdout, fmt.Errorf("%s", msg)
 			}
 			d.printDeployStdout(d.new.Deploy.Stdout, d.new.Deploy.UpdatedAt.Time, isDeleting)
 		}
@@ -239,7 +239,7 @@ func (d *AppStatusDiff) PrintUpdate() (bool, string, error) {
 	failed, errMsg := HasFailed(d.new)
 	if failed {
 		d.statusUI.PrintLogLine(errMsg, "", true, time.Now())
-		return true, d.lastSeenDeployStdout, fmt.Errorf(errMsg)
+		return true, d.lastSeenDeployStdout, fmt.Errorf("%s", errMsg)
 	}
 	return false, d.lastSeenDeployStdout, nil
 }

cli/pkg/kctrl/cmd/core/authoring_ui.go

@@ -59,13 +59,13 @@ func (uiImpl AuthoringUIImpl) PrintActionableText(text string) {
 
 func (uiImpl AuthoringUIImpl) AskForText(textOpts ui.TextOpts) (string, error) {
 	col := color.New(color.Bold)
-	textOpts.Label = fmt.Sprintf(col.Sprint("> ")) + textOpts.Label
+	textOpts.Label = col.Sprint("> ") + textOpts.Label
 	return uiImpl.ui.AskForText(textOpts)
 }
 
 func (uiImpl AuthoringUIImpl) AskForChoice(choiceOpts ui.ChoiceOpts) (int, error) {
 	col := color.New(color.Bold)
-	choiceOpts.Label = fmt.Sprintf(col.Sprint("> ")) + choiceOpts.Label
+	choiceOpts.Label = (col.Sprint("> ")) + choiceOpts.Label
 	return uiImpl.ui.AskForChoice(choiceOpts)
 }
 
@@ -74,5 +74,5 @@ func (uiImpl AuthoringUIImpl) PrintHeaderText(text string) {
 }
 
 func (uiImpl AuthoringUIImpl) PrintHeaderWithContextText(text string, context string) {
-	uiImpl.ui.BeginLinef("%s: %s\n", color.New(color.Bold).Sprintf(text), context)
+	uiImpl.ui.BeginLinef("%s: %s\n", color.New(color.Bold).Sprintf("%s", text), context)
 }

cli/pkg/kctrl/cmd/package/available/values_schema.go

@@ -92,7 +92,7 @@ func (parser *PackageValuesSchemaParser) walkOnValueSchemaProperties(docMap map[
 	default:
 		errMsg := fmt.Sprintf("unable to parse the value schema, the value of key named 'properties' has unsupported"+
 			" type %v. Expected types are: [map[string]interface{}, json.RawMessage] (hint: the valuesSchema might not have any properties)", t)
-		return fmt.Errorf(errMsg)
+		return fmt.Errorf("%s", errMsg)
 	}
 
 	// Base case two: if current level does have properties field but that interface is an empty map, we do not need to