fix: restore discord bot replies

Author: mfreeman451

elixir/threadr/lib/threadr/ingest/bot_qa.ex

@@ -256,7 +256,7 @@ defmodule Threadr.Ingest.BotQA do
   end
 
   defp send_discord_reply(api, channel_id, content) do
-    call_adapter(api, :create_message, [channel_id, %{content: content}])
+    call_adapter(api, :create_message, [parse_discord_channel_id(channel_id), %{content: content}])
   end
 
   defp format_reply(%{platform: "irc", reply_prefix: prefix}, content) do
@@ -371,6 +371,17 @@ defmodule Threadr.Ingest.BotQA do
     Keyword.get(config, :discord_api, Nostrum.Api)
   end
 
+  defp parse_discord_channel_id(channel_id) when is_integer(channel_id), do: channel_id
+
+  defp parse_discord_channel_id(channel_id) when is_binary(channel_id) do
+    case Integer.parse(channel_id) do
+      {parsed, ""} -> parsed
+      _ -> channel_id
+    end
+  end
+
+  defp parse_discord_channel_id(channel_id), do: channel_id
+
   defp emit_question_detected(config, request) do
     Threadr.Ingest.emit_runtime_event(config, :question_detected, %{
       platform: request.platform,

elixir/threadr/test/support/ingest_test_support.ex

@@ -110,3 +110,10 @@ defmodule Threadr.TestDiscordApi do
     {:ok, %{id: "discord-reply-1"}}
   end
 end
+
+defmodule Threadr.TestStrictDiscordApi do
+  def create_message(channel_id, options, pid) when is_integer(channel_id) do
+    send(pid, {:discord_api_create_message, channel_id, options})
+    {:ok, %{id: "discord-reply-1"}}
+  end
+end

elixir/threadr/test/threadr/ingest/discord/bot_qa_test.exs

@@ -61,7 +61,7 @@ defmodule Threadr.Ingest.Discord.BotQATest do
       )
 
     assert_receive {:published_envelope, _envelope}
-    assert_receive {:discord_api_create_message, "12345", %{content: content}}
+    assert_receive {:discord_api_create_message, 12345, %{content: content}}
     assert content =~ "<@1>"
     assert content =~ "what did Alice and Bob talk about last week?"
   end
@@ -99,6 +99,65 @@ defmodule Threadr.Ingest.Discord.BotQATest do
     refute_receive {:discord_api_create_message, _channel_id, _options}, 200
   end
 
+  test "casts Discord channel ids for the real API-style adapter" do
+    tenant = create_tenant!("Discord Bot QA Strict API")
+    actor = create_actor!(tenant.schema_name, "alice")
+    channel = create_channel!(tenant.schema_name, "12345")
+
+    message =
+      create_message!(
+        tenant.schema_name,
+        actor.id,
+        channel.id,
+        "Alice and Bob discussed endpoint isolation last week."
+      )
+
+    create_embedding!(tenant.schema_name, message.id, [0.4, 0.5, 0.6])
+
+    Consumer.put_config(
+      tenant_subject_name: tenant.subject_name,
+      tenant_id: tenant.id,
+      bot_id: "bot-123",
+      channels: ["12345"],
+      publisher: {Threadr.TestPublisher, self()},
+      discord_api: {Threadr.TestStrictDiscordApi, self()},
+      embedding_provider: Threadr.TestEmbeddingProvider,
+      embedding_model: "test-embedding-model",
+      generation_provider: Threadr.TestGenerationProvider,
+      generation_model: "test-chat",
+      discord: %{
+        identity: %{
+          user_id: "999",
+          username: "threadr",
+          global_name: "Threadr"
+        }
+      }
+    )
+
+    :ok =
+      Consumer.handle_event(
+        {:MESSAGE_CREATE,
+         %Message{
+           id: 999_888_778,
+           channel_id: 12_345,
+           guild_id: 54_321,
+           content: "<@999> hello",
+           author: %User{
+             id: 1,
+             username: "alice",
+             global_name: "Alice Display",
+             bot: false
+           },
+           mentions: [%User{id: 999, username: "threadr", global_name: "Threadr"}]
+         }, nil}
+      )
+
+    assert_receive {:published_envelope, _envelope}
+    assert_receive {:discord_api_create_message, 12345, %{content: content}}
+    assert content =~ "<@1>"
+    assert content =~ "hello"
+  end
+
   defp create_tenant!(prefix) do
     suffix = System.unique_integer([:positive])