Skip to content

Commit 5601cf7

Browse files
Copilotnomeguy
andcommitted
Address code review feedback: fix typos and improve code clarity
Co-authored-by: nomeguy <85475922+nomeguy@users.noreply.github.com>
1 parent 0a66ce6 commit 5601cf7

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

src/Authorizer.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -122,7 +122,8 @@ export class Authorizer {
122122
for (const sArray of obj['g']) {
123123
let arr = sArray as string[];
124124
arr = arr.map(v => v.trim())
125-
const pType = arr.shift()
125+
// Remove and discard the pType prefix (e.g., "g") before adding to enforcer
126+
arr.shift();
126127
await this.enforcer.addGroupingPolicy(...arr);
127128
}
128129
}

src/__test__/index.test.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import axios from 'axios';
22
import { Authorizer } from '../index';
33
import { basicModelStr, rbacModelStr } from './models';
4-
import { basicPolicies, rabcPolicies } from './policies';
4+
import { basicPolicies, rbacPolicies } from './policies';
55
import { removeLocalStorage } from '../Cache';
66
import TestServer from './server';
77

@@ -94,7 +94,7 @@ test('Manual mode with RBAC and grouping policies', async () => {
9494
// This tests that 'g' policies are correctly processed
9595
const enforcerData = {
9696
m: rbacModelStr,
97-
p: rabcPolicies,
97+
p: rbacPolicies,
9898
};
9999
await authorizer.setPermission(enforcerData);
100100
await authorizer.setUser('alice');

src/__test__/policies.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,5 @@ function getPolicies(filename: string): string[][] {
1212
}
1313

1414
export const basicPolicies = getPolicies("src/__test__/examples/basic_policy.csv");
15-
export const rabcPolicies = getPolicies("src/__test__/examples/rbac_policy.csv");
15+
export const rbacPolicies = getPolicies("src/__test__/examples/rbac_policy.csv");
1616
export const abacWithObjRulesPolicies = getPolicies("src/__test__/examples/abac_with_obj_rule_policy.csv");

0 commit comments

Comments
 (0)