Add tests

Author: adrw

Diff for: service/src/main/kotlin/app/cash/backfila/dashboard/CreateBackfillAction.kt

@@ -16,7 +16,7 @@ import misk.web.actions.WebAction
 import misk.web.mediatype.MediaTypes
 
 class CreateBackfillAction @Inject constructor(
-  private val callerProvider: @JvmSuppressWildcards ActionScoped<MiskCaller?>,
+  private val caller: @JvmSuppressWildcards ActionScoped<MiskCaller?>,
   private val backfillCreator: BackfillCreator,
 ) : WebAction {
   @Post("/services/{service}/variants/{variant}/create")
@@ -37,7 +37,7 @@ class CreateBackfillAction @Inject constructor(
     request: CreateBackfillRequest,
   ): CreateBackfillResponse {
     // TODO check user has permissions for this service with access api
-    val id = backfillCreator.create(callerProvider.get()!!.user!!, service, variant, request)
+    val id = backfillCreator.create(caller.get()!!.user!!, service, variant, request)
 
     return CreateBackfillResponse(id.id)
   }

Diff for: service/src/test/kotlin/app/cash/backfila/service/listener/AuditClientListenerTest.kt

@@ -156,7 +156,7 @@ class AuditClientListenerTest {
           applicationName = "deep-fryer",
           approverLDAP = "molly",
           automatedChange = true,
-          description = "Backfill started by molly [dryRun=true][service=deep-fryer][backfill=ChickenSandwich][id=${response.backfill_run_id}]",
+          description = "Backfill paused due to error [dryRun=true][service=deep-fryer][backfill=ChickenSandwich][id=${response.backfill_run_id}]",
           richDescription = null,
           environment = "testing",
           detailURL = "/backfills/${response.backfill_run_id}",
@@ -168,6 +168,23 @@ class AuditClientListenerTest {
 
       auditClientListener.runCompleted(Id(response.backfill_run_id))
       assertEquals(4, fakeAuditClient.sentEvents.size)
+      assertEquals(
+        FakeAuditClient.FakeAuditEvent(
+          eventSource = "backfila",
+          eventTarget = "ChickenSandwich",
+          timestampSent = 2147483647,
+          applicationName = "deep-fryer",
+          approverLDAP = "molly",
+          automatedChange = true,
+          description = "Backfill completed [dryRun=true][service=deep-fryer][backfill=ChickenSandwich][id=${response.backfill_run_id}]",
+          richDescription = null,
+          environment = "testing",
+          detailURL = "/backfills/${response.backfill_run_id}",
+          region = "us-west-2",
+          requestorLDAP = "molly",
+        ),
+        fakeAuditClient.sentEvents.last(),
+      )
     }
   }
 }