fix: fix helm install bugs

Author: hsluoyz

controllers/helm.go

@@ -221,12 +221,14 @@ func (c *ApiController) InstallHelmChartStream() {
 	if cfg == nil {
 		c.Ctx.ResponseWriter.ResponseWriter.Header().Set("Content-Type", "text/event-stream")
 		fmt.Fprintf(c.Ctx.ResponseWriter.ResponseWriter, "data: ERROR: cluster not ready\n\n")
+		c.StopRun()
 		return
 	}
 	var req helmInstallReq
 	if err := json.Unmarshal(c.Ctx.Input.RequestBody, &req); err != nil {
 		c.Ctx.ResponseWriter.ResponseWriter.Header().Set("Content-Type", "text/event-stream")
 		fmt.Fprintf(c.Ctx.ResponseWriter.ResponseWriter, "data: ERROR: %s\n\n", err.Error())
+		c.StopRun()
 		return
 	}
 
@@ -247,6 +249,7 @@ func (c *ApiController) InstallHelmChartStream() {
 			flusher.Flush()
 		}
 	}
+	c.StopRun()
 }
 
 // UpgradeHelmRelease upgrades an existing Helm release.

store/helm.go

@@ -372,8 +372,7 @@ func InstallHelmChartStream(ctx context.Context, cfg *rest.Config, releaseName,
 		install.ReleaseName = releaseName
 		install.Namespace = namespace
 		install.CreateNamespace = true
-		install.Wait = true
-		install.Timeout = 5 * time.Minute
+		install.Wait = false
 		if _, err = install.RunWithContext(ctx, helmChart, vals); err != nil {
 			if ctx.Err() != nil {
 				send("ABORTED")