GroupVersionKind() returns empty

Author: Furkhat Kasymov Genii Uulu

internal/actions/csr/svc.go

@@ -15,7 +15,6 @@ import (
 	corev1 "k8s.io/api/core/v1"
 	apierrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/apimachinery/pkg/util/wait"
 	"k8s.io/client-go/kubernetes"
 	"k8s.io/client-go/tools/cache"
@@ -72,12 +71,7 @@ func (m *ApprovalManager) Start(ctx context.Context) error {
 
 	handlerFuncs := cache.ResourceEventHandlerFuncs{
 		AddFunc: func(obj interface{}) {
-			csrObj, ok := obj.(runtime.Object)
-			if !ok {
-				m.log.WithField("object", obj).Warn("object is not a runtime.Object")
-				return
-			}
-			csr, err := wrapper.NewCSR(m.clientset, csrObj)
+			csr, err := wrapper.NewCSR(m.clientset, obj)
 			if err != nil {
 				m.log.WithError(err).Warn("creating csr wrapper")
 				return

internal/actions/csr/wrapper/csr.go

@@ -13,7 +13,6 @@ import (
 	v1 "k8s.io/api/core/v1"
 	k8serrors "k8s.io/apimachinery/pkg/api/errors"
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-	"k8s.io/apimachinery/pkg/runtime"
 	"k8s.io/client-go/kubernetes"
 	certificatesv1 "k8s.io/client-go/kubernetes/typed/certificates/v1"
 	certificatesv1beta1 "k8s.io/client-go/kubernetes/typed/certificates/v1beta1"
@@ -35,21 +34,21 @@ type CSR struct {
 }
 
 // NewCSR validates and creates new certificateRequestFacade.
-func NewCSR(clientset kubernetes.Interface, csrObj runtime.Object) (*CSR, error) {
+func NewCSR(clientset kubernetes.Interface, csrObj interface{}) (*CSR, error) {
 	var (
 		v1   *certv1.CertificateSigningRequest
 		v1b1 *certv1beta1.CertificateSigningRequest
 	)
 	if csrObj == nil {
 		return nil, fmt.Errorf("either v1 or v1beta1 CertificateSigningRequests expected but got none")
 	}
-	switch csrObj.DeepCopyObject().GetObjectKind().GroupVersionKind() {
-	case certv1.SchemeGroupVersion.WithKind("CertificateSigningRequest"):
-		v1 = csrObj.(*certv1.CertificateSigningRequest)
-	case certv1beta1.SchemeGroupVersion.WithKind("CertificateSigningRequest"):
-		v1b1 = csrObj.(*certv1beta1.CertificateSigningRequest)
+	switch csr := csrObj.(type) {
+	case *certv1.CertificateSigningRequest:
+		v1 = csr
+	case *certv1beta1.CertificateSigningRequest:
+		v1b1 = csr
 	default:
-		return nil, fmt.Errorf("either v1 or v1beta1 CertificateSigningRequests expected but got %s", csrObj.DeepCopyObject().GetObjectKind().GroupVersionKind())
+		return nil, fmt.Errorf("either v1 or v1beta1 CertificateSigningRequests expected but got %T", csrObj)
 	}
 	var result CSR
 	var err error

internal/actions/csr/wrapper/csr_test.go

@@ -27,7 +27,7 @@ func TestNewCSR(t *testing.T) {
 	t.Parallel()
 	for _, testcase := range []struct {
 		name   string
-		csrObj runtime.Object
+		csrObj interface{}
 		notOK  bool
 	}{
 		{