Remove the enable/disable for metrics, no point in not doing it always and all castware does this pattern.

Author: Tsonov

cmd/controller/run.go

@@ -181,22 +181,20 @@ func runController(
 		}
 	}()
 
-	// Start http server for metrics if needed
-	if cfg.Metrics.Enabled {
-		go func() {
-			addr := fmt.Sprintf(":%d", cfg.Metrics.Port)
-			log.Infof("starting metrics on %s", addr)
-
-			metrics.RegisterCustomMetrics()
-			metricsMux := metrics.NewMetricsMux()
-			// https://deepsource.com/directory/go/issues/GO-S2114
-			// => This is not a public API and runs in customer cluster; risk should be OK.
-			//nolint:gosec
-			if err := http.ListenAndServe(addr, metricsMux); err != nil {
-				log.Errorf("failed to start metrics http server: %v", err)
-			}
-		}()
-	}
+	// Start http server for metrics
+	go func() {
+		addr := fmt.Sprintf(":%d", cfg.Metrics.Port)
+		log.Infof("starting metrics on %s", addr)
+
+		metrics.RegisterCustomMetrics()
+		metricsMux := metrics.NewMetricsMux()
+		// https://deepsource.com/directory/go/issues/GO-S2114
+		// => This is not a public API and runs in customer cluster; risk should be OK.
+		//nolint:gosec
+		if err := http.ListenAndServe(addr, metricsMux); err != nil {
+			log.Errorf("failed to start metrics http server: %v", err)
+		}
+	}()
 
 	if err := saveMetadata(cfg.ClusterID, cfg, log); err != nil {
 		return err

internal/config/config.go

@@ -54,8 +54,7 @@ type TLS struct {
 }
 
 type Metrics struct {
-	Enabled bool
-	Port    int
+	Port int
 }
 
 type LeaderElection struct {
@@ -154,10 +153,8 @@ func Get() Config {
 		cfg.MaxActionsInProgress = 1000
 	}
 
-	if cfg.Metrics.Enabled {
-		if cfg.Metrics.Port == 0 {
-			cfg.Metrics.Port = 9090
-		}
+	if cfg.Metrics.Port == 0 {
+		cfg.Metrics.Port = 9090
 	}
 
 	return *cfg